172174 - some key events are handled by forms but not marked as such

Status: NEW

(Core :: DOM: Events, defect, P5)

Description

[Kathleen :Brade]

In bug 164481 for Chimera, we had some subtle problems show up because some key
events were not marked as "handled" by forms when they should have been.

Comment 1

[Kathleen :Brade]

Index: mozilla/content/html/content/src/nsHTMLInputElement.cpp
===================================================================
RCS file: /cvsroot/mozilla/content/html/content/src/nsHTMLInputElement.cpp,v
retrieving revision 1.264
diff -u -2 -r1.264 nsHTMLInputElement.cpp
--- mozilla/content/html/content/src/nsHTMLInputElement.cpp	12 Nov 2002
23:03:03 -0000	1.264
+++ mozilla/content/html/content/src/nsHTMLInputElement.cpp	18 Nov 2002 15:15:27
-0000
@@ -1622,4 +1622,7 @@
                 nsEventStatus status = nsEventStatus_eIgnore;
                 shell->HandleDOMEventWithTarget(submitControl, &event, &status);
+
+                // treat the current event as submit so consume it
+                *aEventStatus = nsEventStatus_eConsumeNoDefault;
               } else if (numTextControlsFound == 1) {
                 // If there's only one text control, just submit the form
@@ -1631,4 +1634,7 @@
                 nsEventStatus status  = nsEventStatus_eIgnore;
                 shell->HandleDOMEventWithTarget(form, &event, &status);
+
+                // treat the current event as submit so consume it
+                *aEventStatus = nsEventStatus_eConsumeNoDefault;
               }
             }

Comment 2

[Justin Dolske [:Dolske]]

I'm not sure this is relevant anymore.

Comment 3

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.