Open Bug 1721877 Opened 3 years ago Updated 2 years ago

[Automated review] Automated review flags GMP code as untested

Categories

(Developer Infrastructure :: Source Code Analysis, defect, P3)

Tracking

(Not tracked)

People

(Reporter: bryce, Unassigned)

Details

Phabricator URL: https://phabricator.services.mozilla.com/D120647#3920465

The automated review flags code the runs in the GMP child process as untested. Specifically files such as

  • ChromiumCDMAdapter.h
  • GMPChild.cpp
  • GMPContentChild.cpp

are listed as uncovered.

We have some automated tests that check these paths (e.g. mochitests). How is coverage calculated? I wonder if the GMP's architecture messes with detection.

We have some automated tests that check these paths (e.g. mochitests). How is coverage calculated? I wonder if the GMP's architecture messes with detection.

It could be... Is the GMP child process exiting normally or does it take some shortcut? Is it behind some sort of additional sandbox to the normal one (which we disable in the coverage build)?
Normally, code coverage data is dumped at shutdown.

Severity: -- → S3
Priority: -- → P3
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.