Initial focus in password dialogs messed up

RESOLVED FIXED

Status

()

RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: Biesinger, Assigned: aaronlev)

Tracking

Trunk
x86
Windows 98
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

[guessing at the component]
1. go to above url
2. notice focus is not in the username field

build id 2002100109, win98

this is a regression.

also happens for news username/password, like news://news.cis.dfn.de/at.linux

probably also for IMAP/POP password prompts, but I can't check right now.
To clarify, the focus is on the OK button
(Assignee)

Comment 2

16 years ago
Created attachment 101461 [details] [diff] [review]
Only focuses first button if no textfields -- otherwise the old default behavior occurs, which focuses the first control

Comment 3

16 years ago
Comment on attachment 101461 [details] [diff] [review]
Only focuses first button if no textfields -- otherwise the old default behavior occurs, which focuses the first control

r=sgehani
Attachment #101461 - Flags: review+
Comment on attachment 101461 [details] [diff] [review]
Only focuses first button if no textfields -- otherwise the old default behavior occurs, which focuses the first control

sr=bryner
Attachment #101461 - Flags: superreview+
(Assignee)

Comment 5

16 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Component: Accessibility APIs → Keyboard Navigation
Resolution: --- → FIXED

Comment 6

16 years ago
Comment on attachment 101461 [details] [diff] [review]
Only focuses first button if no textfields -- otherwise the old default behavior occurs, which focuses the first control

>-  if (setCheckbox(gCommonDialogParam.GetString(1), gCommonDialogParam.GetInt(1)))
>+  if (setCheckbox(gCommonDialogParam.GetString(1), gCommonDialogParam.GetInt(1)) &&
>+      gCommonDialogParam.GetInt(3) == 0)  // if no text fields

Unfortunately I didn't have sufficiently reliable internet access otherwise I
would have posted my solution which only checks GetInt(3) although I expect
that the extra test doesn't hurt.
You need to log in before you can comment on or make changes to this bug.