1722019 - [wpt-sync] Sync PR 29762 - Revert "[fsa] Implement truncate for the sync access handle"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 29762 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29762
Details from upstream follow.

b'Henrik Bostr\xc3\xb6m <[e-mail]>' wrote:

Revert "[fsa] Implement truncate for the sync access handle"

This reverts commit 7ddd6ce32e94379d5b7321b2de8ebde9e03c332c.

Reason for revert:

virtual/file-system-access-access-handle/external/wpt/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker.html

Started failing on:

https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.13%20Tests/40088/overview

Original change's description:

[fsa] Implement truncate for the sync access handle

The implementation is ported from the implementation of
Storage Foundation in
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/native_io/native_io_file_async.cc.

This is part of the efforts to merge Storage Foundation into OPFS.

Note that this CL does not contain the implementation for MacOS below
version 10.15. The old MacOS needs special handling, which will be added
in a separate CL.

Bug: chromium:1218431
Change-Id: I8e742fe0beeb93520e521358981f561a83c11732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3044117
Commit-Queue: Andreas Haas \<[e-mail]>
Reviewed-by: Marijn Kruisselbrink \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#904693}

Bug: chromium:1218431
Change-Id: Id8bd9fb310bdf0f38efb2860b87a985f650b617d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3048554
Auto-Submit: Henrik Boström \<[e-mail]>
Commit-Queue: Rubber Stamper \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Owners-Override: Henrik Boström \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#904728}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 29762 applied with additional changes from upstream: 22504c029880a84526a072e1027941155331a0a2

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=edffd776b74bf3091f0b366d6fe128d9b778c35f

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 10 subtests

Status Summary

Firefox

OK : 1
FAIL : 10

Chrome

OK : 1
FAIL : 10

Safari

ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker.html
SyncAccessHandle.close is idempotent: FAIL (Chrome: FAIL)
SyncAccessHandle.close is idempotent when called immediately: FAIL (Chrome: FAIL)
SyncAccessHandle.read fails after SyncAccessHandle.close settles: FAIL (Chrome: FAIL)
SyncAccessHandle.read fails immediately after calling SyncAccessHandle.close: FAIL (Chrome: FAIL)
SyncAccessHandle.write fails after SyncAccessHandle.close settles: FAIL (Chrome: FAIL)
SyncAccessHandle.write fails immediately after calling SyncAccessHandle.close: FAIL (Chrome: FAIL)
SyncAccessHandle.flush fails after SyncAccessHandle.close settles: FAIL (Chrome: FAIL)
SyncAccessHandle.flush fails immediately after calling SyncAccessHandle.close: FAIL (Chrome: FAIL)
SyncAccessHandle.getSize fails after SyncAccessHandle.close settles: FAIL (Chrome: FAIL)
SyncAccessHandle.getSize fails immediately after calling SyncAccessHandle.close: FAIL (Chrome: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca29891e9618
[wpt PR 29762] - Revert "[fsa] Implement truncate for the sync access handle", a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ea5eadfdd62
[wpt PR 29762] - Revert "[fsa] Implement truncate for the sync access handle", a=testonly

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2ea5eadfdd62