Raptor browsertime fails with "Error: Cannot find module '@sitespeed.io/throttle'"
Categories
(Testing :: Performance, defect, P3)
Tracking
(Not tracked)
People
(Reporter: whimboo, Unassigned)
References
Details
I tried to run the following command, which then errors out:
./mach raptor --browsertime --test amazon --browsertime-geckodriver target/debug/geckodriver
As it looks like the node package sitespeed.io/throttle
doesn't get installed:
19:27:41 INFO - raptor-browsertime Info: b"Error: Cannot find module '@sitespeed.io/throttle'"
19:27:41 INFO - raptor-browsertime Info: b'Require stack:'
19:27:41 INFO - raptor-browsertime Info: b'- /Users/henrik/code/gecko/tools/browsertime/node_modules/browsertime/lib/connectivity/index.js'
19:27:41 INFO - raptor-browsertime Info: b'- /Users/henrik/code/gecko/tools/browsertime/node_modules/browsertime/lib/core/engine/index.js'
19:27:41 INFO - raptor-browsertime Info: b'- /Users/henrik/code/gecko/tools/browsertime/node_modules/browsertime/index.js'
19:27:41 INFO - raptor-browsertime Info: b'- /Users/henrik/code/gecko/tools/browsertime/node_modules/browsertime/bin/browsertime.js'
19:27:41 INFO - raptor-browsertime Info: b' at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)'
19:27:41 INFO - raptor-browsertime Info: b' at Function.Module._load (internal/modules/cjs/loader.js:667:27)'
19:27:41 INFO - raptor-browsertime Info: b' at Module.require (internal/modules/cjs/loader.js:887:19)'
19:27:41 INFO - raptor-browsertime Info: b' at require (internal/modules/cjs/helpers.js:74:18)'
19:27:41 INFO - raptor-browsertime Info: b' at Object.<anonymous> (/Users/henrik/code/gecko/tools/browsertime/node_modules/browsertime/lib/connectivity/index.js:5:18)'
19:27:41 INFO - raptor-browsertime Info: b' at Module._compile (internal/modules/cjs/loader.js:999:30)'
19:27:41 INFO - raptor-browsertime Info: b' at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)'
19:27:41 INFO - raptor-browsertime Info: b' at Module.load (internal/modules/cjs/loader.js:863:32)'
19:27:41 INFO - raptor-browsertime Info: b' at Function.Module._load (internal/modules/cjs/loader.js:708:14)'
19:27:41 INFO - raptor-browsertime Info: b' at Module.require (internal/modules/cjs/loader.js:887:19)'
19:27:41 INFO - raptor-browsertime Info: b' at require (internal/modules/cjs/helpers.js:74:18)'
19:27:41 INFO - raptor-browsertime Info: b' at Object.<anonymous> (/Users/henrik/code/gecko/tools/browsertime/node_modules/browsertime/lib/core/engine/index.js:12:49)'
19:27:41 INFO - raptor-browsertime Info: b' at Module._compile (internal/modules/cjs/loader.js:999:30)'
19:27:41 INFO - raptor-browsertime Info: b' at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)'
19:27:41 INFO - raptor-browsertime Info: b' at Module.load (internal/modules/cjs/loader.js:863:32)'
19:27:41 INFO - raptor-browsertime Info: b' at Function.Module._load (internal/modules/cjs/loader.js:708:14) {'
19:27:41 INFO - raptor-browsertime Info: b" code: 'MODULE_NOT_FOUND',"
19:27:41 INFO - raptor-browsertime Info: b' requireStack: ['
19:27:41 INFO - raptor-browsertime Info: b" '/Users/henrik/code/gecko/tools/browsertime/node_modules/browsertime/lib/connectivity/index.js',"
19:27:41 INFO - raptor-browsertime Info: b" '/Users/henrik/code/gecko/tools/browsertime/node_modules/browsertime/lib/core/engine/index.js',"
19:27:41 INFO - raptor-browsertime Info: b" '/Users/henrik/code/gecko/tools/browsertime/node_modules/browsertime/index.js',"
19:27:41 INFO - raptor-browsertime Info: b" '/Users/henrik/code/gecko/tools/browsertime/node_modules/browsertime/bin/browsertime.js'"
19:27:41 INFO - raptor-browsertime Info: b' ]'
19:27:41 INFO - raptor-browsertime Info: b'}'
Reporter | ||
Comment 1•3 years ago
|
||
Note that it's required to run mach browsertime --setup
before, even when this command says:
0:01.75 [WARNING] This tool is UNSUPPORTED by the perftest team and it is NOT recommended to use for performance testing. Instead, if you are looking to perform performance tests on your patch, use `./mach raptor --browsertime`.
Updated•3 years ago
|
Comment 2•3 years ago
|
||
(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #1)
Note that it's required to run
mach browsertime --setup
before, even when this command says:0:01.75 [WARNING] This tool is UNSUPPORTED by the perftest team and it is NOT recommended to use for performance testing. Instead, if you are looking to perform performance tests on your patch, use `./mach raptor --browsertime`.
:whimboo it's unclear, does running mach browsertime --setup
resolve this for you?
Updated•3 years ago
|
Reporter | ||
Comment 3•3 years ago
|
||
Yes, it solved it. But as written in the mach command's output, running this command shouldn't be required.
Comment 4•3 years ago
|
||
(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #3)
Yes, it solved it. But as written in the mach command's output, running this command shouldn't be required.
This is a bug, we want to discourage use of ./mach browsertime
but not ./mach browsertime --setup
. :kimberlythegeek could you file a bug for adding an exception for the --setup
flag when displaying this message?
Description
•