Closed Bug 1722099 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29768 - Make SaturateInf more consistent for infinite and large finite values.

Categories

(Core :: Web Painting, task, P4)

Product:
Core
Component:
Web Painting
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29768 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29768
Details from upstream follow.

b'L. David Baron <dbaron@chromium.org>' wrote:

Make SaturateInf more consistent for infinite and large finite values.

This changes SaturateInf to treat infinite values the same way it treats
very large finite values, by compromising between the two behaviors.
Instead of clamping infinity all the way down to
std::numeric_limits\<int>::max(), it clamps both infinity and large
floats to 2^(-30) times std::numeric_limits\<float>::max().

Fixed: 1228695
Change-Id: I0c6719bbe6ef079ccf0bf14dd54f22e17b681915

Reviewed-on: https://chromium-review.googlesource.com/3049556
WPT-Export-Revision: e576066ed79bfe15176f510b74c0cc1c78ef1fbc

Component: web-platform-tests → Web Painting
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/866159bd8b69
[wpt PR 29768] - Make FloatQuad::BoundingBox treat large finite values like infinite ones., a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/947ccc853c9c
[wpt PR 29768] - Make FloatQuad::BoundingBox treat large finite values like infinite ones., a=testonly

https://hg.mozilla.org/mozilla-central/rev/947ccc853c9c

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.