1722150 - Crash in [@ geckoservo::glue::Servo_ImportRule_GetSheet]

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

From bug 1719963. 22 crashes from 15 installations, all on Windows.

Crash report: https://crash-stats.mozilla.org/report/index/6c6fe12c-351e-4ff9-aa62-985290210724

Reason: EXCEPTION_BREAKPOINT

Top 10 frames of crashing thread:

0 xul.dll RustMozCrash mozglue/static/rust/wrappers.cpp:16
1 xul.dll mozglue_static::panic_hook mozglue/static/rust/lib.rs:89
2 xul.dll core::ops::function::Fn::call<fn ../53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b/library/core/src/ops/function.rs:227
3 xul.dll std::panicking::rust_panic_with_hook ../53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b//library/std/src/panicking.rs:595
4 xul.dll std::panicking::begin_panic_handler::{{closure}} ../53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b//library/std/src/panicking.rs:495
5 xul.dll std::sys_common::backtrace::__rust_end_short_backtrace<closure-0, !> ../53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b//library/std/src/sys_common/backtrace.rs:141
6 xul.dll std::panicking::begin_panic_handler ../53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b//library/std/src/panicking.rs:493
7 xul.dll core::panicking::panic_fmt ../53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b//library/core/src/panicking.rs:92
8 xul.dll core::panicking::panic ../53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b//library/core/src/panicking.rs:50
9 xul.dll geckoservo::glue::Servo_ImportRule_GetSheet servo/ports/geckolib/glue.rs:2606

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Unwrap in that function is failing...

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Hi Tyson, have fuzzers seen something of this sort? It'd be great to have some sort of test-case to figure out what might be going wrong.

Comment 3

[Tyson Smith [:tsmith]]

Sorry I don't see anything.

jkratzer: Can you please double check?

Comment 4

[Jason Kratzer [:jkratzer]]

Unfortunately, I'm not seeing anything reported by the fuzzers either.

Comment 5

[Julien Cristau [:jcristau] (back April 22)]

This is the #2 content process top crash in nightly this week, we'll need a fix or backout before going to beta on Monday.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Yeah, we should back out from beta if we don't find a repro for it.

Comment 7

[Julien Cristau [:jcristau] (back April 22)]

Is there a chance we'll find a repro this week? If not we might as well back out from central already?

Comment 8

[Emilio Cobos Álvarez (:emilio)]

I'm hoping that Jason / Tyson might find one? Any chance you see something similar now? Note that the crash is a rust unwrap() failure...

Comment 9

[Jason Kratzer [:jkratzer]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #8)

I'm hoping that Jason / Tyson might find one? Any chance you see something similar now? Note that the crash is a rust unwrap() failure...

Unfortunately, no - still no crashes. Do you have any idea how this might occur? I could try and craft some more targeted tests that might trigger this.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Bug 1719963 backed out.
https://hg.mozilla.org/mozilla-central/rev/03637911a02a3d366a3f66869bbb76c7626a55ee