found while testing bug 172018, 2002.10.02.07 mach-o on 10.1.5 and 10.2.1. 1. save a page, eg, hit cmd-S or select File > Save Page... 2. it doesn't matter what save option you use, or where you save it (though try to remember the destination you do choose). click Save. 3. the download progress dlg appears, and when it's done the Launch File and Show File Location buttons will be enabled. a. click Show File Location. results: the only thing that happens is that the application switches from mozilla to the desktop (finder). expected: you should be switched to the finder, but a new finder window should appear showing the file location. this is a problem if you saved somewhere other than the desktop. b. click Launch File. results: i'm switched to the desktop and a new finder window appears showing me the *location* of the file. (the expected behavior for (a).) expected: a new browser window should open and load the file.
not a problem with buffy (CFM) builds
Summary: mach-o: Launch and Show Location buttons in progress dlg don't work as expected → [mach-o] Launch and Show Location buttons in progress dlg don't work as expected
The external helper app code is not hooked up to the new Mach-0 file impl. That needs to happen.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.2beta
behavior has changed when i test this with 2002.10.14.07 mach-o bits on 10.1.5: "launch file" now works. eg, if i save an html file, the default browser is launched and the file is displayed. however, "show file location" still just switches me to the Finder (and no more). sdagley had pointed out a strange thing where, if he saved a file as say, /Users/sairuh/Documents/foo.html, it would appear in the download progress dlg as /Users/sairuh/foo.html/Documents. i don't see this with today's mach-o build (path is fine). it's just that the "show file location" button is (still) misbehaving.
This must be related to the mach-o build not being AppleEvent aware as the code looks right (or the kAEMakeObjectsVisible AE doesn't like getting an FSRef)
> or the kAEMakeObjectsVisible AE doesn't like getting an FSRef Thank you. That was it. I thought that, whatever type the receiving and wanted, AE coercion would make the FSRef into what it wanted.
Created attachment 102890 [details] [diff] [review] patch Fixes Reveal(), makes bracket placement consistent. Need r=/sr=.
Comment on attachment 102890 [details] [diff] [review] patch sr=sfraser
Attachment #102890 - Flags: superreview+
Comment on attachment 102890 [details] [diff] [review] patch r=sdagley :-)
Attachment #102890 - Flags: review+
Comment on attachment 102890 [details] [diff] [review] patch a=dbaron for trunk checkin
Attachment #102890 - Flags: approval+
Fixed. Checking in nsLocalFileOSX.cpp; /cvsroot/mozilla/xpcom/io/nsLocalFileOSX.cpp,v <-- nsLocalFileOSX.cpp new revision: 1.3; previous revision: 1.2 done
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Verified in the 2003-01-14-07 Mach -O build under 10.2.3.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.