[mach-o] Launch and Show Location buttons in progress dlg don't work as expected

VERIFIED FIXED in mozilla1.2beta

Status

Core Graveyard
File Handling
VERIFIED FIXED
16 years ago
2 years ago

People

(Reporter: sairuh (rarely reading bugmail), Assigned: Conrad Carlen (not reading bugmail))

Tracking

Trunk
mozilla1.2beta
PowerPC
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
found while testing bug 172018, 2002.10.02.07 mach-o on 10.1.5 and 10.2.1.

1. save a page, eg, hit cmd-S or select File > Save Page...
2. it doesn't matter what save option you use, or where you save it (though try
to remember the destination you do choose). click Save.
3. the download progress dlg appears, and when it's done the Launch File and
Show  File Location buttons will be enabled.

a. click Show File Location.

results: the only thing that happens is that the application switches from
mozilla to the desktop (finder).

expected: you should be switched to the finder, but a new finder window should
appear showing the file location. this is a problem if you saved somewhere other
than the desktop.

b. click Launch File.

results: i'm switched to the desktop and a new finder window appears showing me
the *location* of the file. (the expected behavior for (a).)

expected: a new browser window should open and load the file.
(Reporter)

Comment 1

16 years ago
not a problem with buffy (CFM) builds
(Reporter)

Updated

16 years ago
Summary: mach-o: Launch and Show Location buttons in progress dlg don't work as expected → [mach-o] Launch and Show Location buttons in progress dlg don't work as expected
(Assignee)

Comment 2

16 years ago
The external helper app code is not hooked up to the new Mach-0 file impl. That
needs to happen.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.2beta
(Reporter)

Comment 3

16 years ago
behavior has changed when i test this with 2002.10.14.07 mach-o bits on 10.1.5:
"launch file" now works. eg, if i save an html file, the default browser is
launched and the file is displayed.

however, "show file location" still just switches me to the Finder (and no more).

sdagley had pointed out a strange thing where, if he saved a file as say,
/Users/sairuh/Documents/foo.html, it would appear in the download progress dlg
as /Users/sairuh/foo.html/Documents. i don't see this with today's mach-o build
(path is fine). it's just that the "show file location" button is (still)
misbehaving.

Comment 4

16 years ago
This must be related to the mach-o build not being AppleEvent aware as the code
looks right (or the kAEMakeObjectsVisible AE doesn't like getting an FSRef)
(Assignee)

Comment 5

16 years ago
> or the kAEMakeObjectsVisible AE doesn't like getting an FSRef

Thank you. That was it. I thought that, whatever type the receiving and wanted,
AE coercion would make the FSRef into what it wanted.
(Assignee)

Comment 6

16 years ago
Created attachment 102890 [details] [diff] [review]
patch

Fixes Reveal(), makes bracket placement consistent. Need r=/sr=.

Comment 7

16 years ago
Comment on attachment 102890 [details] [diff] [review]
patch

sr=sfraser
Attachment #102890 - Flags: superreview+

Comment 8

16 years ago
Comment on attachment 102890 [details] [diff] [review]
patch

r=sdagley :-)
Attachment #102890 - Flags: review+
Comment on attachment 102890 [details] [diff] [review]
patch

a=dbaron for trunk checkin
Attachment #102890 - Flags: approval+
(Reporter)

Updated

16 years ago
QA Contact: sairuh → petersen
(Assignee)

Comment 10

16 years ago
Fixed.

Checking in nsLocalFileOSX.cpp;
/cvsroot/mozilla/xpcom/io/nsLocalFileOSX.cpp,v  <--  nsLocalFileOSX.cpp
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 11

16 years ago
Verified in the 2003-01-14-07 Mach -O build under 10.2.3.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.