1722341 - Bundle gfx.json blocklist information on Android

Reporter

Description

•

3 years ago

For background, see comments at bug 1715788, particularly the conclusion at https://bugzilla.mozilla.org/show_bug.cgi?id=1715788#c13.

The gfx blocklist is now working again, but only when updated remotely because gfx.json is not bundled with Android by default. Although the blocklist doesn't contain any entries right now for Android, it may contain more in the future. Moreover, it's only 32kb (uncompressed), so the size difference is acceptable.

:Gijs (he/him)

Updated

•

3 years ago

Severity: -- → N/A

Priority: -- → P3

Summary: Bundle gfx.json on Android → Bundle gfx.json blocklist information on Android

[ex-Mozilla] Agi Sferro | :agi

Assignee

Comment 1

•

2 years ago

Attached file Bug 1722341 - Include gfx blocklist in Android dumps. — Details

Phabricator Automation

Updated

•

2 years ago

Assignee: nobody → agi

Status: NEW → ASSIGNED

Pulsebot

Comment 2

•

2 years ago

Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/24fbaf568416
Include gfx blocklist in Android dumps. r=Gijs,jnicol,calu

Iulian Moraru

Comment 3

•

2 years ago

Backed out for causing xpcshell failures on test_blocklist_clients.js.

Push with the backed out revision
Push with the first occurrence of the failures

Failure log

Backout link

[task 2022-06-17T19:23:23.620Z] 19:23:23     INFO -  TEST-START | toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_clients.js
[task 2022-06-17T19:23:23.697Z] 19:23:23     INFO -  adb launch_application: am startservice -W -n 'org.mozilla.geckoview.test_runner/org.mozilla.geckoview.test_runner.XpcshellTestRunnerService$i0' -a android.intent.action.MAIN --es env0 XPCOM_DEBUG_BREAK=stack-and-abort --es env1 MOZ_CRASHREPORTER=1 --es env2 MOZ_CRASHREPORTER_NO_REPORT=1 --es env3 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env4 MOZ_DEVELOPER_REPO_DIR=/builds/worker/checkouts/gecko --es env5 MOZ_DISABLE_CONTENT_SANDBOX=1 --es env6 MOZ_FETCHES_DIR=/builds/worker/fetches --es env7 MOZ_DISABLE_SOCKET_PROCESS=1 --es env8 LD_LIBRARY_PATH=/data/local/tmp/test_root/xpcb --es env9 MOZ_LINKER_CACHE=/data/local/tmp/test_root/xpcb --es env10 GRE_HOME=/data/local/tmp/test_root/xpcb --es env11 XPCSHELL_TEST_PROFILE_DIR=/data/local/tmp/test_root/xpc/p/8afd6389-0d52-42c7-8b34-e32397a26ac2 --es env12 HOME=/data/local/tmp/test_root/xpc/p --es env13 XPCSHELL_TEST_TEMP_DIR=/data/local/tmp/test_root/xpc/tmp/5595128a-b83e-4fbd-a93e-6f8d7e05abed --es env14 MOZ_ANDROID_DATA_DIR=/data/local/tmp/test_root/xpcb --es env15 MOZ_IN_AUTOMATION=1 --es env16 MOZ_ANDROID_CPU_ABI=x86_64 --es env17 MOZHTTP2_PORT=36725 --es env18 MOZNODE_EXEC_PORT=39469 --es env19 TMPDIR=/data/local/tmp/test_root/xpc/p/8afd6389-0d52-42c7-8b34-e32397a26ac2 --es env20 XPCSHELL_MINIDUMP_DIR=/data/local/tmp/test_root/xpc/minidumps/8afd6389-0d52-42c7-8b34-e32397a26ac2 --es arg0 -g --es arg1 /data/local/tmp/test_root/xpcb --es arg2 --greomni --es arg3 /data/local/tmp/test_root/xpcb/geckoview-test_runner.apk --es arg4 -m --es arg5 -e --es arg6 'const _HEAD_JS_PATH = "/data/local/tmp/test_root/xpc/head.js";' --es arg7 -e --es arg8 'const _MOZINFO_JS_PATH = "/data/local/tmp/test_root/xpc/p/8afd6389-0d52-42c7-8b34-e32397a26ac2/mozinfo.json";' --es arg9 -e --es arg10 'const _PREFS_FILE = "/data/local/tmp/test_root/xpc/user.js";' --es arg11 -e --es arg12 'const _TESTING_MODULES_DIR = "/data/local/tmp/test_root/xpc/m";' --es arg13 -f --es arg14 /data/local/tmp/test_root/xpc/head.js --es arg15 -e --es arg16 'const _HEAD_FILES = ["/data/local/tmp/test_root/xpc/toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/head.js", "/data/local/tmp/test_root/xpc/toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/../head_addons.js"];' --es arg17 -e --es arg18 'const _JSDEBUGGER_PORT = 0;' --es arg19 -e --es arg20 'const _TEST_CWD = "/data/local/tmp/test_root/xpc/toolkit/mozapps/extensions/test/xpcshell/rs-blocklist";' --es arg21 -e --es arg22 'const _TEST_FILE = ["test_blocklist_clients.js"];' --es arg23 -e --es arg24 'const _TEST_NAME = "toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_clients.js";' --es arg25 -e --es arg26 '_execute_test(); quit(0);' --ez use_multiprocess True --es out_file /data/local/tmp/test_root/xpc/logs/xpcshell-8d9fa958-0032-47e8-aa42-f755aa4091b0.log
[task 2022-06-17T19:23:24.004Z] 19:23:24     INFO -  remotexpcshelltests.py | toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_clients.js | 11048 | Launched Test App
[task 2022-06-17T19:23:25.006Z] 19:23:25     INFO -  remotexpcshelltests.py | toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_clients.js | 11048 | Application ran for: 0:00:01.384904
[task 2022-06-17T19:23:25.092Z] 19:23:25  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_clients.js | xpcshell return code: 0
[task 2022-06-17T19:23:25.092Z] 19:23:25     INFO -  TEST-INFO took 1471ms
[task 2022-06-17T19:23:25.092Z] 19:23:25     INFO -  >>>>>>>
[task 2022-06-17T19:23:25.092Z] 19:23:25     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2022-06-17T19:23:25.092Z] 19:23:25     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2022-06-17T19:23:25.092Z] 19:23:25     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2022-06-17T19:23:25.092Z] 19:23:25     INFO -  running event loop
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_clients.js | Starting setup
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  (xpcshell/head.js) | test setup pending (2)
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804337	addons.manager	DEBUG	Application has been upgraded"
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804338	addons.manager	DEBUG	Starting provider: XPIProvider"
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804338	addons.xpi	DEBUG	startup"
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804339	addons.xpi	DEBUG	List of built-in add-ons is missing or invalid.: [Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIXPCComponents_Utils.readUTF8URI]"  nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: startup :: line 2474"  data: no] Stack trace: startup()@resource://gre/modules/addons/XPIProvider.jsm:2474
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  callProvider()@resource://gre/modules/AddonManager.jsm:234
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  _startProvider()@resource://gre/modules/AddonManager.jsm:542
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  startup()@resource://gre/modules/AddonManager.jsm:748
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  startup()@resource://gre/modules/AddonManager.jsm:3471
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  observe()@resource://gre/modules/addonManager.js:79
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  promiseStartupManager()@resource://testing-common/AddonTestUtils.jsm:788
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  setup()@test_blocklist_clients.js:51
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  _run_next_test/<()@/data/local/tmp/test_root/xpc/head.js:1766
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  _run_next_test()@/data/local/tmp/test_root/xpc/head.js:1766
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  run()@/data/local/tmp/test_root/xpc/head.js:812
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  _do_main()@/data/local/tmp/test_root/xpc/head.js:240
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  _execute_test()@/data/local/tmp/test_root/xpc/head.js:597
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  -e:1"
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804343	addons.xpi	INFO	SystemAddonLocation directory is missing"
[task 2022-06-17T19:23:25.098Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804366	addons.xpi	INFO	Removing all system add-on upgrades."
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804368	addons.xpi	DEBUG	checkForChanges"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804368	addons.xpi	DEBUG	Loaded add-on state: ${}"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804371	addons.xpi	DEBUG	scanForChanges changed: false, state: {}"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804371	addons.xpi	DEBUG	Empty XPI database, setting schema version preference to 35"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804372	addons.xpi	DEBUG	No changes found"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804385	addons.manager	DEBUG	Registering shutdown blocker for XPIProvider"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804385	addons.manager	DEBUG	Provider finished startup: XPIProvider"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804386	addons.manager	DEBUG	Completed startup sequence"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  (xpcshell/head.js) | test setup finished (2)
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_clients.js | Starting test_initial_dump_is_loaded_as_synced_when_collection_is_empty
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  (xpcshell/head.js) | test test_initial_dump_is_loaded_as_synced_when_collection_is_empty pending (2)
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  TEST-PASS | toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_clients.js | test_initial_dump_is_loaded_as_synced_when_collection_is_empty - [test_initial_dump_is_loaded_as_synced_when_collection_is_empty : 57] Expected initial remote settings dump for addons - true == true
[task 2022-06-17T19:23:25.099Z] 19:23:25  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_clients.js | test_initial_dump_is_loaded_as_synced_when_collection_is_empty - [test_initial_dump_is_loaded_as_synced_when_collection_is_empty : 57] Expected initial remote settings dump for gfx - true == false
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  test_blocklist_clients.js:test_initial_dump_is_loaded_as_synced_when_collection_is_empty:57
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  /data/local/tmp/test_root/xpc/head.js:_do_main:240
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  /data/local/tmp/test_root/xpc/head.js:_execute_test:597
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  -e:null:1
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  exiting test
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  _abort_failed_test@/data/local/tmp/test_root/xpc/head.js:868:20
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  do_report_result@/data/local/tmp/test_root/xpc/head.js:969:5
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  Assert<@/data/local/tmp/test_root/xpc/head.js:75:21
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  proto.report@resource://testing-common/Assert.jsm:228:10
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  equal@resource://testing-common/Assert.jsm:270:8
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  test_initial_dump_is_loaded_as_synced_when_collection_is_empty@test_blocklist_clients.js:57:14
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  _do_main@/data/local/tmp/test_root/xpc/head.js:240:6
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  _execute_test@/data/local/tmp/test_root/xpc/head.js:597:5
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  @-e:1:1
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  exiting test
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "Force a GC"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804484	addons.xpi-utils	DEBUG	Starting async load of XPI database /data/local/tmp/test_root/xpc/p/8afd6389-0d52-42c7-8b34-e32397a26ac2/extensions.json"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804491	addons.xpi-utils	DEBUG	Rebuilding XPI database with no extensions"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804492	addons.manager	DEBUG	before shutdown"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804493	addons.manager	DEBUG	shutdown"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804494	addons.manager	DEBUG	Calling shutdown blocker for XPIProvider"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804494	addons.xpi	DEBUG	shutdown"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804494	addons.xpi-utils	DEBUG	shutdown"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  "CONSOLE_MESSAGE: (info) 1655493804501	addons.manager	DEBUG	Async provider shutdown done"
[task 2022-06-17T19:23:25.099Z] 19:23:25     INFO -  <<<<<<<
[task 2022-06-17T19:23:25.200Z] 19:23:25     INFO -  Cleaning up profile for /builds/worker/workspace/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_clients.js folder: /data/local/tmp/test_root/xpc/p/8afd6389-0d52-42c7-8b34-e32397a26ac2
[task 2022-06-17T19:23:25.455Z] 19:23:25     INFO -  INFO | Result summary:
[task 2022-06-17T19:23:25.456Z] 19:23:25     INFO -  INFO | Passed: 765
[task 2022-06-17T19:23:25.456Z] 19:23:25  WARNING -  INFO | Failed: 1
[task 2022-06-17T19:23:25.456Z] 19:23:25  WARNING -  One or more unittests failed.
[task 2022-06-17T19:23:25.456Z] 19:23:25     INFO -  INFO | Todo: 8
[task 2022-06-17T19:23:25.456Z] 19:23:25     INFO -  INFO | Retried: 1
[task 2022-06-17T19:23:25.456Z] 19:23:25     INFO -  SUITE-END | took 883s

Flags: needinfo?(agi)

Chris Peterson [:cpeterson]

Updated

•

2 years ago

Priority: P3 → P1

Whiteboard: [geckoview:m104]

Pulsebot

Comment 4

•

2 years ago

Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b50411d3c5b
Include gfx blocklist in Android dumps. r=Gijs,jnicol,calu

Sandor Molnar[:smolnar]

Comment 5

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/8b50411d3c5b

Status: ASSIGNED → RESOLVED

Closed: 2 years ago

status-firefox104: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 104 Branch

Chris Peterson [:cpeterson]

Updated

•

2 years ago

Blocks: 1715788

status-firefox102: --- → wontfix

status-firefox103: --- → wontfix

Updated

•

2 years ago

No longer blocks: 1715788

Updated

•

2 years ago

Flags: needinfo?(agi)

Bugzilla

Quick Search

Bundle gfx.json blocklist information on Android

Categories

(Toolkit :: Blocklist Implementation, task, P1)

Tracking

()

People

(Reporter: robwu, Assigned: agi)

References

Details

(Whiteboard: [geckoview:m104])

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Updated

Comment 1

Updated

Comment 2

Comment 3

Updated

Comment 4

Comment 5

Updated

Updated

Updated

Attachment

General

Description

File Name

Content Type