1722356 - Minor cleanup in layout

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

These patches are written while I'm reading our layout code to understand some bugs.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1722356 - Remove frameToAddToList in ConstructFrameFromItemInternal(). r?#layout-reviewers

If we need to construct a scroll frame, we can just assign it to
primaryFrame variable.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1722356 - Restore grid reftests in layout/reftests/css-grid/reftest.list. r?#layout-reviewers

These grid reftests were removed accidentally in
https://hg.mozilla.org/mozilla-central/diff/46fc8d45948300d9e635c684d01ac7a4444dd6c8/layout/reftests/css-grid/reftest.list

Depends on D120866

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1722356 - Cleanup the logic computing button's rect in nsComboboxControlFrame. r?#layout-reviewers

This shouldn't change the behavior.

Depends on D120867

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce5abbede80c
Remove frameToAddToList in ConstructFrameFromItemInternal(). r=emilio
https://hg.mozilla.org/integration/autoland/rev/45f88f959f57
Restore grid reftests in layout/reftests/css-grid/reftest.list. r=emilio
https://hg.mozilla.org/integration/autoland/rev/142407ff717c
Cleanup the logic computing button's rect in nsComboboxControlFrame. r=emilio

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ce5abbede80c
https://hg.mozilla.org/mozilla-central/rev/45f88f959f57
https://hg.mozilla.org/mozilla-central/rev/142407ff717c