1722371 - [wpt-sync] Sync PR 29788 - Make <selectmenu>'s parts search always a flat tree traversal that skips nested <selectmenu>s.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 29788 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29788
Details from upstream follow.

b'Dan Clark <[e-mail]>' wrote:

Make <selectmenu>'s parts search always a flat tree traversal that skips nested <selectmenu>s.

Per an OpenUI resolution [1], a \<selectmenu>'s search for parts should
be a flat tree traversal that doesn't descend into nested \<selectmenu>
or \<select> elements.

This change updates \<selectmenu> to use the resolved-upon behavior.
As a consequence, the parts chosen depend only on tree structure, not
on the order of insertion for dynamically inserted parts.

[1] See https://www.w3.org/2021/06/17-openui-irc

Bug: 1209219,1191121
Change-Id: Ia68c782b7972317b8e6abdcfff5e52ece34a3ed0

Reviewed-on: https://chromium-review.googlesource.com/3053078
WPT-Export-Revision: a2a7ece8ef4c5fced21ea02940ffe7e0be3061c3

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=21e8f58315edfe52d4b62f3b31be730c9e0ef6f5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 4 subtests

Status Summary

Firefox

OK : 3
FAIL : 12

Chrome

OK : 2
PASS : 5
CRASH: 1
FAIL : 3

Safari

OK : 2
FAIL : 8
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/forms/the-selectmenu-element/selectmenu-nested.tentative.html
A <selectmenu> shouldn't apply controller code to parts nested in a <selectmenu> child: FAIL (Chrome: FAIL, Safari: FAIL)
A <selectmenu> shouldn't apply controller code to parts nested in a <select> child: FAIL (Chrome: FAIL, Safari: FAIL)
A nested button part in a nested <selectmenu> shouldn't get controller code even if it comes first in document order: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/forms/the-selectmenu-element/selectmenu-parts-structure.tentative.html
To receive option part controller code, an element labeled as an option must be a descendant of the listbox part in a flat tree traversal: FAIL (Chrome: PASS, Safari: FAIL)
To receive button part controller code, an element labeled as a button must not be a descendant of the listbox part in a flat tree traversal: FAIL (Chrome: PASS, Safari: FAIL)
To receive listbox part controller code, an element labeled as a listbox must not be a descendant of the button part in a flat tree traversal: FAIL (Chrome: PASS, Safari: FAIL)
Button controller code should be applied in flat tree traversal order regardless of dynamic insertion order: FAIL (Chrome: FAIL, Safari: FAIL)
Listbox controller code should be applied in flat tree traversal order regardless of dynamic insertion order: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/forms/the-selectmenu-element/selectmenu-popup.tentative.html
Opening the popup and clicking an option should change the selectmenu's value: FAIL
With custom button and popup: opening the popup and clicking an option should change the selectmenu's value: FAIL
Clicking a popup with no listbox part does nothing: FAIL
Clicking a popup with a listbox that was removed does nothing: FAIL

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/301d234e2a09
[wpt PR 29788] - Make <selectmenu>'s parts search always a flat tree traversal that skips nested <selectmenu>s., a=testonly
https://hg.mozilla.org/integration/autoland/rev/3897c8c73bd5
[wpt PR 29788] - Update wpt metadata, a=testonly

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/301d234e2a09
https://hg.mozilla.org/mozilla-central/rev/3897c8c73bd5