Closed Bug 1722389 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 29793 - [LayoutNG] Nested fixedpos in multicol w/ viewport CB

Categories

(Core :: Layout: Columns, task, P4)

task

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29793 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29793
Details from upstream follow.

b'Alison Maher <almaher@microsoft.com>' wrote:

[LayoutNG] Nested fixedpos in multicol w/ viewport CB

There were a couple of cases that resulted in a prepaint crash for a
nested fixedpos in a multicol whose containing block existed outside
the multicol.

  1. When walking a missed OOF in prepaint, we skip over any OOF children
    so that they can be found during fragment traversal. However, if that
    OOF child is a fixedpos, and its CB is outside the multicol, we will
    miss walking that fixedpos in fragment traversal.

To fix this, keep track of any fixedpos elements that we could miss in
this way in |pending_fixedpos_missables_|, and walk those after we
finish walking the multicol.

  1. If a fixedpos is nested in a non-missed OOF, and its CB is outside
    the multicol, we could miss walking it in prepaint when we check
    if the fragmentainer is the first for node (ie. we'll skip the fixedpos
    if the OOF parent starts in fragmentainer that is not the first).
    Instead, check if the parent is the first for node to make sure that we
    walk legacy-contained OOFs exactly once.

Bug: 1200328
Change-Id: I623afe38eef6c2abf827ed75ee78935adc7052ec
Reviewed-on: https://chromium-review.googlesource.com/3050673
WPT-Export-Revision: 13c612bbf66885e2d621199a8575b2c41a4ff0f3

Component: web-platform-tests → Layout: Columns
Product: Testing → Core
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e1d71d196903 [wpt PR 29793] - [LayoutNG] Nested fixedpos in multicol w/ viewport CB, a=testonly https://hg.mozilla.org/integration/autoland/rev/7531b78d4ffd [wpt PR 29793] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.