172242 - Search Page command doesn't work when no search page is provided

Status: VERIFIED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Lawrence Goldman]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021002
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021002

When I click on Search Page, either from the Go menu or in the toolbar, the
following error message appears: "www.foo.bar could not be found.  Please check
the name and try again."

Reproducible: Always

Steps to Reproduce:
1.Choose Search Page from the Go menu, or--
2.Click on the Search icon in the Toolbar
3.

Actual Results:  
An error message appears.

Expected Results:  
Bring up the Google search page (always happened until this latest nightly build)

Comment 1

[Mike Pinkerton (not reading bugmail)]

i'll take a look. bizarro

Comment 2

[Greg K.]

It does WorkForMe using Chimera/2002100104 on 10.1.5.

Comment 3

[Chris Petersen]

The key to reproducing is disable "Use System Prefrence" in Home Page tab of
Navigator prefs. Make sure search field is empty. Go back to browser toolbar and
press search button. Reproduce under 2002-10-04-04 with 10.2.1.

Comment 4

[Simon Fraser [no longer active]]

Mine.

Comment 5

[Mike Pinkerton (not reading bugmail)]

simon said he'd look. my prefs file has "" as the user pref for
"chimera.search_page" so at some point i guess it got written out as null.
deleting that line caused it all to work just fine, but a lot of people must
have that line as well from some past build.

we do a lot of checking that NSLocalizedStringFromTable doesn't fail. do we
really need to be that concerned? 

also, if we do fall back to a hardcoded string, perhaps it should be google.com
rather than www.foo.bar, no? ;)

Comment 6

[Simon Fraser [no longer active]]

Fix checked in.

Comment 7

[Chris Petersen]

Verified in the 2002-10-11-04.