Closed Bug 1722444 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29798 - Fix Canvas 2d attribute spelling

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29798 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29798
Details from upstream follow.

b'Yi Xu <yiyix@chromium.org>' wrote:

Fix Canvas 2d attribute spelling

TextRendering properties are saved as "Auto", "GeometricPrecision",
"OptimizeSpeed", etc, which is wrong and it is supposed to start with
lower case letters instead, i.e., "auto", "geometricPrecision",
"optimizeSpeed", etc. This similar mistake were made for FontKerning,
FontVariant and FontStretch.

This Cl fixes the spelling issues for these Canvas 2D attributes.

Bug: 1230242

Change-Id: I8e5e4cd60fcf75ec5de984a880c5b5b9426a75e6
Reviewed-on: https://chromium-review.googlesource.com/3055118
WPT-Export-Revision: f7f1fdfe7bdffd5c3050703fde2c8900860d8249

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 12 tests and 1 subtests

Status Summary

Firefox

OK : 12
FAIL: 12

Chrome

OK : 12
FAIL: 12

Safari

OK : 12
FAIL: 12

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/canvas/offscreen/text/2d.text.drawing.style.fontKerning.html
Testing basic functionalities of fontKerning for canvas: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/drawing-text-to-the-canvas/2d.text.drawing.style.fontKerning.html
Testing basic functionalities of fontKerning for canvas: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.drawing.style.fontKerning.with.uppercase.html
Testing basic functionalities of fontKerning for canvas: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/drawing-text-to-the-canvas/2d.text.drawing.style.fontKerning.with.uppercase.html
Testing basic functionalities of fontKerning for canvas: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.drawing.style.fontKerning.with.uppercase.worker.html
Testing basic functionalities of fontKerning for canvas: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/drawing-text-to-the-canvas/2d.text.drawing.style.fontVariant.settings.html
Testing basic functionalities of fontKerning for canvas: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.drawing.style.fontKerning.worker.html
Testing basic functionalities of fontKerning for canvas: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/drawing-text-to-the-canvas/2d.text.drawing.style.textRendering.settings.html
Testing basic functionalities of textRendering in Canvas: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.drawing.style.fontVariant.settings.html
Testing basic functionalities of fontKerning for canvas: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.drawing.style.fontVariant.settings.worker.html
Testing basic functionalities of fontKerning for canvas: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.drawing.style.textRendering.settings.html
Testing basic functionalities of textRendering in Canvas: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.drawing.style.textRendering.settings.worker.html
Testing basic functionalities of textRendering in Canvas: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e305ec092bad
[wpt PR 29798] - Fix Canvas 2d attribute spelling, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e305ec092bad

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.