1722501 - Migrate style editor to will-navigate

Status: RESOLVED FIXED

(DevTools :: Style Editor, task)

Description

[Alexandre Poirot [:ochameau]]

We introduced DOCUMENT_EVENT's dom-loading shouldBeIgnoredAsRedundantWithTargetAvailable attribute in order to mitigate the fact that will-navigate wasn't working nicely over all times of navigations. But this has been fixed now. will-navigate should fire in all types of navigations.

We should be able to use will-navigate instead of a subtle combination of target-available + dom-loading.
And then remove this convoluted flag.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1722501 - [devtools] Migrate styleeditor to will-navigate.

We used to handle navigation with a subtle and complex combination of target-available + dom-loading.
Just because we were missing will-navigate event in some cases.
But will-navigate is now reliable and is fired in all types of navigations.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1722501 - [devtools] Remove now unused DOCUMENT_EVENT's dom-loading's shouldBeIgnoredAsRedundantWithTargetAvailable attribute.

Comment 3

[Alexandre Poirot [:ochameau]]

Making this block bug 1698891 as this fixes an intermittent failure with (at least) devtools/client/styleeditor/test/browser_styleeditor_inline_friendly_names.js on debug builds:
https://treeherder.mozilla.org/logviewer?job_id=346486475&repo=try
The editors count appear to be invalid when reloading the page with server targets.
Migrating to will-navigate fixes this. I suspect it relates to shouldBeIgnoredAsRedundantWithTargetAvailable logic being broken with server targets.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0ad3156c4a1
[devtools] Migrate styleeditor to will-navigate. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/1371dd75c9c7
[devtools] Remove now unused DOCUMENT_EVENT's dom-loading's shouldBeIgnoredAsRedundantWithTargetAvailable attribute. r=nchevobbe

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e0ad3156c4a1
https://hg.mozilla.org/mozilla-central/rev/1371dd75c9c7