1722515 - "ipc/mscom/ActivationContext.cpp(7,10): fatal error: 'mozilla/mscom/ActivationContext.h' file not found" bustage with --disable-accessibility

Status: RESOLVED FIXED

(Core :: IPC: MSCOM, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Looks like a regression from the changes in bug 1719849.

ipc/mscom/ActivationContext.cpp(7,10): fatal error: 'mozilla/mscom/ActivationContext.h' file not found
#include "mozilla/mscom/ActivationContext.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Comment 1

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1722515 - Only build ActivationContext.cpp in mozglue if a11y r?Jamie

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d2c5e6b61ff
Only build ActivationContext.cpp in mozglue if a11y r=Jamie

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/logviewer?job_id=347269232&repo=try&lineNumber=18377 says this is still broken

Comment 4

[Alex Thayer [:alexical] (she/her)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)

https://treeherder.mozilla.org/logviewer?job_id=347269232&repo=try&lineNumber=18377 says this is still broken

I don't mind putting up a fix for this, as it looks obvious what's wrong. However, just so I'm certain I understand the history of this bug, it looks like that should have been broken prior to my changes in bug 1719849?

Comment 5

[Ryan VanderMeulen [:RyanVM]]

I'm not sure. I've been building locally with bug 1719849 and bug 1714212 backed out without issue up to today, so it's not something I've been seeing with the "other" bustage resolved.

Comment 6

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1722515 - Fix WindowsMessageLoop no-a11y breakage r?Jamie

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/2d2c5e6b61ff

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/654a8320a95f
Fix WindowsMessageLoop no-a11y breakage r=Jamie

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/654a8320a95f