Closed Bug 1722538 Opened 3 years ago Closed 3 years ago

Make TraceWeakEdge accept null edges

Categories

(Core :: JavaScript: GC, task, P3)

task

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

Almost all calls to TraceWeakEdge check whether the edge is null first. That's understandable because a weak edge should always be cleared if the thing it references dies. We should just build this check into the function.

This patch also changes the signature to only accept WeakHeapPtr<T> and changed
a couple of HeapPtr<T> to WeakHeapPtr<T> where the edge was being traced with
this function.

Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/84359d014a92
Make TraceWeakEdge accept null edges r=sfink
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: