172262 - when placing bookmarks and nav toolbar on the same row, unneccesary space is used

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[David Tenser [:djst]]

When customizing the toolbars, you can drag the bookmarks toolbar to the same
row as the navigation toolbar, which is /great/, but that toolbar takes up more
horizontal space than is needed.

Steps to reprod:
1. Create four sub-folders in the bookmarks toolbar
2. Customize toolbars and drag one of the folders up to the navigation toolbar.

I've tried this on both Windows and Linux. Using version 0.2.

Comment 1

[David Tenser [:djst]]

Attachment: Screenshot of the problem.

As you can see, there are empty space at the right of "Folder 4".

Comment 2

[Asa Dotzler [:asa]]

I also noticed this and thought that I reported it but can't find it now so I
guess I didn't. Thanks for your help in testing Phoenix and reporting bugs. 

Comment 3

[Tuukka Tolvanen (sp3000)]

Attachment: dump teh xul flex

*shrug* fwiw

Comment 4

[Joe Hewitt (gone)]

Comment on attachment 101566 [details]
dump teh xul flex

If we want to remove the flex, don't put flex="0", just remove the flex
attribute altogether.

We'll also have to specify a min-width on bookmarks-toolbar in case you remove
all your bookmarks, or else it will disappear.

Comment 5

[Asa Dotzler [:asa]]

I tested this and it works for the customize problem but it makes it so that you
can't as easily drop bookmarks on the empty space to the right of your last
bookmark in the bookmarks bar. 

Comment 6

[Asa Dotzler [:asa]]

adding pch since this impacts bookmarks toolbar.

Comment 7

[Tuukka Tolvanen (sp3000)]

re comment 4: An empty toolbar space with min-width wouldn't in a lot of cases
be any more discoverable than no empty space at all; there should propably be
some visible thingy to indicate an empty bookmark-toolbar-part (for bug 171242
also).

re comment 5: For me the drop area is 8px wide, when the last item is a folder;
cf. drop area at the beginning ot the bar is 12px, if the first item is a
folder. It is smaller than 1/4 the window though ;)

Comment 8

[Tuukka Tolvanen (sp3000)]

ah, right, when the bookmark-toolbar-part is alone on a toolbar it gets silly
w/o flex, true, that's not good

Comment 9

[Tuukka Tolvanen (sp3000)]

Seems this could be fixed nicely using flexgroup, should this depend on bug
93175? (or supporting decimals for flex so it could be something like 0.00001,
but that would be silly anyway)

Comment 10

[David Hyatt]

--> me

Comment 11

[David Hyatt]

--> fixed.

Comment 12

[David Tenser [:djst]]

I'm speechless! :)

Comment 13

[Tuukka Tolvanen (sp3000)]

...but, unless my build is magically screwed (which is never entirely unlikely),
it makes the bookmarks toolbar part not extend to the end of the toolbar if it
is the last item on the toolbar, which is annoying since the part does not
indicate its right edge i.e. the end of the drop area (comment 5)

Comment 14

[Brant Gurganus]

VERIFIED Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030714
Mozilla Firebird/0.6

Comment 15

[Simon Paquet [:sipaq]]

Taking QA Contact