when placing bookmarks and nav toolbar on the same row, unneccesary space is used

VERIFIED FIXED in Phoenix0.3

Status

()

Firefox
Toolbars and Customization
VERIFIED FIXED
16 years ago
12 years ago

People

(Reporter: djst, Assigned: David Hyatt)

Tracking

unspecified
Phoenix0.3
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

16 years ago
When customizing the toolbars, you can drag the bookmarks toolbar to the same
row as the navigation toolbar, which is /great/, but that toolbar takes up more
horizontal space than is needed.

Steps to reprod:
1. Create four sub-folders in the bookmarks toolbar
2. Customize toolbars and drag one of the folders up to the navigation toolbar.

I've tried this on both Windows and Linux. Using version 0.2.
(Reporter)

Comment 1

16 years ago
Created attachment 101487 [details]
Screenshot of the problem.

As you can see, there are empty space at the right of "Folder 4".

Comment 2

16 years ago
I also noticed this and thought that I reported it but can't find it now so I
guess I didn't. Thanks for your help in testing Phoenix and reporting bugs. 
Assignee: hyatt → hewitt
Created attachment 101566 [details]
dump teh xul flex

*shrug* fwiw

Comment 4

16 years ago
Comment on attachment 101566 [details]
dump teh xul flex

If we want to remove the flex, don't put flex="0", just remove the flex
attribute altogether.

We'll also have to specify a min-width on bookmarks-toolbar in case you remove
all your bookmarks, or else it will disappear.
Attachment #101566 - Flags: needs-work+

Comment 5

16 years ago
I tested this and it works for the customize problem but it makes it so that you
can't as easily drop bookmarks on the empty space to the right of your last
bookmark in the bookmarks bar. 

Comment 6

16 years ago
adding pch since this impacts bookmarks toolbar.
re comment 4: An empty toolbar space with min-width wouldn't in a lot of cases
be any more discoverable than no empty space at all; there should propably be
some visible thingy to indicate an empty bookmark-toolbar-part (for bug 171242
also).

re comment 5: For me the drop area is 8px wide, when the last item is a folder;
cf. drop area at the beginning ot the bar is 12px, if the first item is a
folder. It is smaller than 1/4 the window though ;)
ah, right, when the bookmark-toolbar-part is alone on a toolbar it gets silly
w/o flex, true, that's not good
Seems this could be fixed nicely using flexgroup, should this depend on bug
93175? (or supporting decimals for flex so it could be something like 0.00001,
but that would be silly anyway)
(Assignee)

Comment 10

16 years ago
--> me
Assignee: hewitt → hyatt
(Assignee)

Comment 11

16 years ago
--> fixed.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Reporter)

Comment 12

16 years ago
I'm speechless! :)

Updated

16 years ago
Target Milestone: --- → Phoenix0.3
...but, unless my build is magically screwed (which is never entirely unlikely),
it makes the bookmarks toolbar part not extend to the end of the toolbar if it
is the last item on the toolbar, which is annoying since the part does not
indicate its right edge i.e. the end of the drop area (comment 5)

Comment 14

15 years ago
VERIFIED Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030714
Mozilla Firebird/0.6
Status: RESOLVED → VERIFIED
Taking QA Contact
QA Contact: asa → bugzilla

Updated

12 years ago
QA Contact: bugzilla → toolbars
You need to log in before you can comment on or make changes to this bug.