1722655 - Missing reload icon when the button is moved to customize main list or in overflow

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Catalin Sasca, Desktop QA [:csasca]]

Attachment: reload icon missing.gif

Affected versions

• Firefox 91.0b8
• Firefox 92.0a1

Affected platforms

• Windows 7 & 10
• macOS 11
• Ubuntu 18.04

Steps to reproduce

1. Launch Firefox
2. Access Customize mode
3. Drag the reload button to the main list or in overflow

Expected result

• The reload icon is still visible

Actual result

• The reload button is missing

Regression range

• This is most likely a recent regression, there was a recent bug where the reload icon was misplaced and now is missing. Will see for a regression.

Additional notes

• The issue can be seen in the attachment.

Comment 1

[Alin Ilea, Desktop QA]

Hi,
Attaching the regression range made on Windows 10x64:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1977e3ba8e22e13b07615682edd09c7231b54da2&tochange=a51628e3d9559952ddd68dbb6034b8ce40c80fb0

Comment 2

[Sam Johnson]

Attachment: Bug 1722655 - Scope reload button alignment adjustments to toolbar r?#desktop-theme-reviewers

This prevents sizing issues in other contexts, such as the overflow panel
and customize view, and the button arguably only appears misaligned
next to the back/forward buttons anyway.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48eadadd4e44
Scope reload button alignment adjustments to toolbar r=Gijs

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/48eadadd4e44

Comment 5

[:Gijs (he/him)]

Comment on attachment 9233724 [details]
Bug 1722655 - Scope reload button alignment adjustments to toolbar r?#desktop-theme-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Missing icon for the reload button when it is in some places
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): 1-line CSS change specific to this icon
• String changes made/needed: None

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9233724 [details]
Bug 1722655 - Scope reload button alignment adjustments to toolbar r?#desktop-theme-reviewers

css fix, approved for 91 rc1

Comment 7

[Catalin Sasca, Desktop QA [:csasca]]

Verified that the icon is fixed on 92.0a1 (2021-08-01). Tests were performed on macOS 10.15.7, Windows 10 and Ubuntu 20.04.

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9acc4ffc5f62

Comment 9

[Catalin Sasca, Desktop QA [:csasca]]

Verified that the icon is fixed on 91.0 as well. Tests were performed on macOS 10.15.7, Windows 10 and Ubuntu 20.04.