1722669 - Tab context menu show number of tabs affected by the action

Status: NEW

(Firefox :: Tabbed Browser, enhancement)

Description

[Antonin LOUBIERE]

All actions in the context menu that affect multiple tabs should show the number of tabs affected. In bug 1629205, we change "Close Tabs" to show the number of tabs affected, I think, to be consistent, we should change all the context actions.

Comment 1

[Negritas Sergiu, Desktop QA]

Hello Antonin and thank you for your contribution! This issue posted looks more like an enhancement than a defect. I will mark it as new in order for our developers to look into it and take into consideration for further releases!

Have a nice day!

Comment 2

[Antonin LOUBIERE]

Attachment: Bug 1722669 - Improve History:UndoCloseTab updates. r=dao

Improve History:UndoCloseTab updates by observing sessionstore-closed-objects-changed.

Comment 3

[Antonin LOUBIERE]

Attachment: Bug 1722669 - Add number of tabs affected in tab context menu. r=dao,flod

Add number of tabs affected by the action in tab context menu.

Depends on D121596

Comment 4

[Antonin LOUBIERE]

Attachment: Bug 1722669 - Show number of tabs affected in toolbar context. r=flod,dao

Show number of tabs affected by an action in the toolbar context menu.

Depends on D121598

Comment 5

[Francesco Lodolo [:flod]]

Have you tried running tests for this patch? I can't really help with that, but you seem to have some failures related to your patch
https://treeherder.mozilla.org/jobs?repo=try&revision=176c4f8ae55835031c5a0792177cc79afd988f2b&selectedTaskRun=btFXeAnARtiSdr1eQSw6Bw.0

Comment 6

[Antonin LOUBIERE]

Thanks, no I haven't run any tests for this patch, I will investigate.

Comment 7

[Antonin LOUBIERE]

Hello, I have some questions on phabricator, I have created a function to use l10n in the updateContextMenu function and I was wondering if I should use this function for all l10n use in this function. Thank you.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:pyjacpp, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 9

[Francesco Lodolo [:flod]]

As far as I can tell, tests still needed to be reviewed. I also shouldn't be the one pushing this type of patches, as I'm reviewing only for the FTL bits.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.