1722691 - ESLint warnings do not appear in phabricator

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P2)

Description

[Mark Banner (:standard8)]

Bug 1703664 recently enabled display of lint warnings in Phabricator. However, it doesn't work for ESLint.

This is due to the ESLint taskcluster configuration passing --quiet to ESLint, which quiets all warnings.

I believe this is a left-over from the early days when we didn't have warnings support in the Lint harness. Now we do, we can remove that option, and warnings will not show up as errors on the main CI, but they will show up on Phabricator

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1722691 - Enable ESLint in CI to report warnings when required. r?marco!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1722691 - Allow hooks to report the count of ESLint warnings as well as errors. r?marco!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b4cc6d84515
Enable ESLint in CI to report warnings when required. r=marco
https://hg.mozilla.org/integration/autoland/rev/61f62fe3c2fa
Allow hooks to report the count of ESLint warnings as well as errors. r=marco

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5b4cc6d84515
https://hg.mozilla.org/mozilla-central/rev/61f62fe3c2fa