Closed Bug 1722706 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 29818 - Attempt to de-flake simulcast WPTs.

Categories

(Core :: WebRTC, task, P4)

Product:
Core
Component:
WebRTC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29818 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29818
Details from upstream follow.

b'Henrik Bostr\xc3\xb6m <hbos@chromium.org>' wrote:

Attempt to de-flake simulcast WPTs.

I believe the reason for flakily timing out is that ramp-up does not
happen quickly enough. Because I am unable to change the getUserMedia()
resolution in external/wpt/webrtc/simulcast/simulcast.js (this causes
timeout, either because the camera resolution is not supported by the
fake capturer or because webrtc does not send QQVGA, not sure?) this CL
changes the simulcast tests only to do 2 layers instead of 3.

The tests are already marked as having a long timeout so not sure how
else to de-flake other than to reduce the bitrate.

If any of the tests starts flaking again we should mark them all as
flaky and file a common bug for all tests instead of having one crbug
per test.

Bug: chromium:1223773, chromium:1225643, chromium:1229785, chromium:1230534
Change-Id: I7a78ffc63a0521e4f971611d28c283c512371f43
Reviewed-on: https://chromium-review.googlesource.com/3057576
WPT-Export-Revision: f1485d8590078d8b4aea9f690eaf4bf2bb515fbf

Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 1 subtests

Status Summary

Firefox

OK : 4
FAIL: 4

Chrome

OK : 4
PASS: 4

Safari

OK : 4
PASS: 4

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/webrtc/simulcast/basic.https.html
Basic simulcast setup with two spatial layers: FAIL
/webrtc/simulcast/h264.https.html
H264 simulcast setup with two spatial layers: FAIL
/webrtc/simulcast/setParameters-active.https.html
Simulcast setParameters active=false stops sending frames: FAIL
/webrtc/simulcast/vp8.https.html
VP8 simulcast setup with two spatial layers: FAIL

New Tests That Don't Pass

/webrtc/simulcast/basic.https.html
Basic simulcast setup with two spatial layers: FAIL (Chrome: PASS, Safari: PASS)
/webrtc/simulcast/h264.https.html
H264 simulcast setup with two spatial layers: FAIL (Chrome: PASS, Safari: PASS)
/webrtc/simulcast/setParameters-active.https.html
Simulcast setParameters active=false stops sending frames: FAIL (Chrome: PASS, Safari: PASS)
/webrtc/simulcast/vp8.https.html
VP8 simulcast setup with two spatial layers: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/023ab32ceb8e [wpt PR 29818] - Attempt to de-flake simulcast WPTs., a=testonly https://hg.mozilla.org/integration/autoland/rev/9c12ed482b5c [wpt PR 29818] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/023ab32ceb8e
https://hg.mozilla.org/mozilla-central/rev/9c12ed482b5c

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.