Closed Bug 1722751 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29819 - Fix fuzzy matching on dynamic-content-change-rendering.html

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29819 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29819
Details from upstream follow.

b'Philip Rogers <pdr@chromium.org>' wrote:

Fix fuzzy matching on dynamic-content-change-rendering.html

I added fuzzy matching to this test in https://crrev.com/905947 but that
caused the test to fail everywhere [1] due to requiring a certain number
of pixels to be different. This patch fixes that so the test now passes.

I confirmed locally using the WPT runner that the test failed before
https://crrev.com/905947 and now passes. I am unable to reproduce the
original pixel differences seen on wpt.fyi so this is still a
speculative fix.

[1] https://wpt.fyi/results/html/semantics/forms/the-option-element/dynamic-content-change-rendering.html?label=master&label=experimental&aligned&q=dynamic-content-change-rendering.html

Change-Id: I8ea0572fee2b84d518df2daff51742155f3b4846
Reviewed-on: https://chromium-review.googlesource.com/3059121
WPT-Export-Revision: 0dd989959baa01f4133f77a3e6312fdffbadbe29

PR 29819 applied with additional changes from upstream: f93baa8f6c6aa82287a3f49491f34114d6a301a5
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

TIMEOUT: 1

Chrome

FAIL : 1

Safari

FAIL : 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/forms/the-option-element/dynamic-content-change-rendering.html: TIMEOUT (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d22d32a93d4
[wpt PR 29819] - Fix fuzzy matching on dynamic-content-change-rendering.html, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4d22d32a93d4

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.