1722767 - [Scale 1.5] Popups are broken in sway

Status: RESOLVED MOVED

(Core :: Widget: Gtk, defect, P3)

Description

[ojab]

Attachment: MOZ_LOG="WidgetScreen:5" firefox

Menus & right-click popups don't show up after https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0c51eaf636b089097500fc721b31d99dcd92b0a3&tochange=02514549f3a78a80b922dc2224d039c6db2a10d8 (https://bugzilla.mozilla.org/show_bug.cgi?id=1718507#c30)

Comment 1

[ojab]

Attachment: Screen recording

Looks like there are no popups instead of popups are not shown until hover.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Please run with MOZ_LOG="WidgetScreen:5 WidgetPopup:5" env variable and attach the log here.
Thanks.

Comment 3

[ojab]

Attachment: MOZ_LOG="WidgetScreen:5 WidgetPopup:5" firefox

Comment 4

[Sawyer Bergeron]

Attachment: Output with MOZ_LOG="WidgetScreen:5 WidgetPopup:5" set

Here's both the log and a screen recording as I reproduce this. I believe it's the same behavior, but the popups do sometimes flicker into view.

This is on Wayfire (also based on wlroots), running on wlroots git from 3 days ago.

Is there any additional logging that would be helpful?

Screen recording of behavior: https://drive.google.com/file/d/1pVtA3zUDGAWtVigJuvCtCjvC0LBgmmev/view?usp=sharing

Comment 5

[Aidan Harris]

Attachment: firefox-good.log (2021-07-19)

Comment 6

[Aidan Harris]

Attachment: firefox-bad.log (2021-07-20)

Comment 7

[ojab]

Filled https://github.com/swaywm/sway/issues/6426 about it.

Comment 8

[ojab]

Attachment: `MOZ_LOG="WidgetScreen:5 WidgetPopup:5" firefox` with sway debug log enabled

Maybe it would be more clear with additional sway debug logging.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

I just tested that on Fedora 34 / sway-1.6-1.fc34.x86_64 / latest trunk but I can't reproduce it - popups are shown correctly.
I see lots of nsWindow::OnScaleChanged() signals - do you use multi monitor system? Is the popup missing on second monitor or so?

Comment 10

[luis.pabon]

I am running a multi monitor setup, but it also happens when laptop is undocked. Popups don't show on any display. The issue where addon popups wouldn't show on some outputs seems to have got worse.

Just to point out this issue is new on current nightly. FF 91 and earlier show the old issue with popups not showing on some outputs when they had different scales.

Comment 11

[ojab]

Single monitor with 1.5 scale here (and log from this config), tested with scale=1 and popups shows fine. So I guess enabled scaling is the culprit?

Comment 12

[Martin Stránský [:stransky] (ni? me)]

How can I set the 1.5 scale please?
Thanks.

Comment 13

[ojab]

swaymsg output '*' scale 1.5 in the running session or output * scale 1.5 in config.

Comment 14

[Martin Stránský [:stransky] (ni? me)]

I can reproduce it with the scale, Thanks.

Comment 15

[ojab]

BTW, tested with scale 2 and popups also missing, looks like it's about scaling and not about fractional scaling in particular.

Comment 16

[frankbernier]

I'm also using sway, not using any scaling, and have been experiencing this issue these past weeks on FF nightly.

Comment 17

[Chris Morgan]

I also found this, mozregression pointing me to the patch from bug 1718507 as the cause of the regression.

Arch Linux, sway-hidpi-git (AUR, a package that includes patches for high-DPI XWayland), scale 1.5. Also reproducible with scale 2, same symptoms exactly.

While bisecting, though, I noticed an interesting related issue: before the 1718507 patch, popups weren’t entirely visually reliable; sometimes they wouldn’t render, or would render a bit late. e.g. press Alt+H to open the Help menu, then keep tapping Left to cycle through the menus, and quite often it doesn’t render the menu. But in that case, it’s fully interactive, it just didn’t draw; do something like pressing Up/Down or hovering over another menu item and it redraws and draws properly. That issue is still reproducible, though less often, at scale 1 today.

At first I thought that might be related to a root cause and that the 1718507 patch might just be triggering that, but since then the failure is definitely somewhat different, so I’m not sure if there’s a common root cause or not. The popup that is broken is still keyboard- and mouse-interactive: Alt+H A opens the About Nightly window (… which is still not a floating window as it should be, per bug 1681158), and Alt+H followed by clicking in the place where that About Nightly menu item should be works as well. But it won’t redraw on hover like it used to, and the Left trick to cycle through menus is mostly broken, e.g. {Alt+H Left Escape I} opens Tools → Page Info, compared with {Alt+H Left I} before the patch. So I’m pretty sure there’s something concretely wonky about the popup windows now, even if the two issues happen to be related. But they’re still similar enough that I figured I’d at least mention it.

Comment 18

[Chris Morgan]

Another detail I accidentally deleted from my comment: bug 1717230 may be related, being something about popup windows consistently not rendering under Sway on a high-DPI output, but it’s from a month before the specific breakage here.

Comment 19

[Martin Stránský [:stransky] (ni? me)]

This is a bug on Sway side - we don't get xdg_positioner callback from wayland compositor. Let's track that at https://github.com/swaywm/sway/issues/6426

Comment 22

[Martin Stránský [:stransky] (ni? me)]

I think Bug 1727836 is a variant of this one.