Closed Bug 1722789 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29823 - Handle font values that contain "var()" for OffscreenCanvas

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29823 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29823
Details from upstream follow.

b'Anders Hartvoll Ruud <andruud@chromium.org>' wrote:

Handle font values that contain "var()" for OffscreenCanvas

This is an offscreen equivalent to Bug 1131922. The fix for that
bug introduced CSSParser::ParseFont, which handles var() and CSS-wide
keywords correctly.

Use CSSParser::ParseFont for OffscreenCanvasRenderingContext2D as well.

Fixed: 1233430
Change-Id: Ic2119c64dec428f3b34f7fc0c15c86b6bcfe9195
Reviewed-on: https://chromium-review.googlesource.com/3058649
WPT-Export-Revision: 2223aea1a005470d7e36704e71fb496ac4460780

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL: 2

Chrome

OK : 2
FAIL: 2

Safari

OK : 2
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/canvas/offscreen/text/2d.text.font.parse.invalid.html
OffscreenCanvas test: 2d.text.font.parse.invalid: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.font.parse.invalid.worker.html
2d: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd00068d3ad8
[wpt PR 29823] - Handle font values that contain "var()" for OffscreenCanvas, a=testonly

https://hg.mozilla.org/mozilla-central/rev/cd00068d3ad8

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.