1722799 - UITour highlight appears as a solid color rectangle instead of a translucent highlight

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Molly Howell (she/her) (mostly inactive)]

Bug 1708735 added this line (also in the other platform-specific versions of that file), which serves its intended purpose, but also accidentally selects the UI Tour highlight, because it's a panel containing a shadow slot with part="content". We'll need to override that property for the highlight's slot element.

Comment 1

[Molly Howell (she/her) (mostly inactive)]

Attachment: Bug 1722799 - Prevent the UITour highlight background from having a solid background. r=Gijs

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1708735

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b48ea29a1ee
Prevent the UITour highlight background from having a solid background. r=Gijs

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6b48ea29a1ee

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Is this something you wanted to nominate for Beta uplift before next week's RC?

Comment 6

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 9233609 [details]
Bug 1722799 - Prevent the UITour highlight background from having a solid background. r=Gijs

Beta/Release Uplift Approval Request

• User impact if declined: Any use of UITour that attempts to highlight an item in the browser UI will instead just draw a solid white rectangle over that item.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch only touches the styles that apply specifically to the UITour highlight panel.
• String changes made/needed:

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9233609 [details]
Bug 1722799 - Prevent the UITour highlight background from having a solid background. r=Gijs

css regression fix, approved for 91 rc1

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f63421679d97