Closed Bug 1722831 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29832 - Cache Storage: Fix null deref with explicit undefined passed

Categories

(Core :: DOM: Service Workers, task, P4)

Product:
Core
Component:
DOM: Service Workers
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29832 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29832
Details from upstream follow.

b'Joshua Bell <jsbell@chromium.org>' wrote:

Cache Storage: Fix null deref with explicit undefined passed

Given the IDL definition of two methods with args of the form
(optional request, optional options), the bindings code expects two
overloads in the implementation. The bindings code maps calls to the
overloads differently if an explicit undefined is passed for request
with no options vs. an explicit undefined is passed with an options
arg, and the code wasn't expecting
the request to be null.

Bug: 1232955
Change-Id: I2ea29151dfaf4e764f221200ef4acb4784334a34

Reviewed-on: https://chromium-review.googlesource.com/3059555
WPT-Export-Revision: d8c018a7928abb90fb9ef9247b692c48cee73019

Component: web-platform-tests → DOM: Service Workers
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 16 subtests

Status Summary

Firefox

OK : 6
PASS : 98

Chrome

CRASH: 6

Safari

OK : 6
PASS : 98

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0fc69929c5ae
[wpt PR 29832] - Cache Storage: Fix null deref with explicit undefined passed, a=testonly

https://hg.mozilla.org/mozilla-central/rev/0fc69929c5ae

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.