Closed Bug 1722832 Opened 3 years ago Closed 3 years ago

Streamline UX for `./mach ide vscode` with existing settings or in remote shells

Categories

(Developer Infrastructure :: Developer Environment Integration, enhancement)

enhancement

Tracking

(firefox93 fixed)

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: nika, Assigned: nika)

References

Details

Attachments

(1 file)

This patch has a few minor improvements to ./mach ide vscode to make it nicer to use in various situations. Specifically:

  • Tries to locate the code using shutil.which in addition to the existing methods so that the binary is found when being run from within a vscode remote shell.
  • If locating the code binary fails, only prompts to ask whether or not to continue, rather than requiring entering the complete path. The only use of the vscode command is to start an instance connected to the correct path, so if no binary was found, a message is logged instead. (bug 1699943)
  • When changes need to be made to the settings.json file, a full diff is shown between the old and new files, rather than just showing the computed state before and after.
  • If parsing the existing settings.json file fails (e.g. because there were c-style comments in it - see bug 1670997), the diff is shown and an additional warning is emitted to ask if the change should be made.

This patch has a few minor improvements to ./mach ide vscode to make
it nicer to use in various situations. Specifically:

  • Tries to locate the code using shutil.which in addition to the
    existing methods so that the binary is found when being run from
    within a vscode remote shell.

  • If locating the code binary fails, only prompts to ask whether or not
    to continue, rather than requiring entering the complete path. The
    only use of the vscode command is to start an instance connected to the
    correct path, so if no binary was found, a message is logged instead.
    (bug 1699943)

  • When changes need to be made to the settings.json file, a full diff is
    shown between the old and new files, rather than just showing the
    computed state before and after.

  • If parsing the existing settings.json file fails (e.g. because there
    were c-style comments in it - see bug 1670997), the diff is shown and
    an additional warning is emitted to ask if the change should be made.

Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/839dd4005fc9 Streamline UX for `./mach ide vscode` with existing settings or in remote shells, r=andi
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: