Streamline UX for `./mach ide vscode` with existing settings or in remote shells
Categories
(Developer Infrastructure :: Developer Environment Integration, enhancement)
Tracking
(firefox93 fixed)
Tracking | Status | |
---|---|---|
firefox93 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
References
Details
Attachments
(1 file)
This patch has a few minor improvements to ./mach ide vscode
to make it nicer to use in various situations. Specifically:
- Tries to locate the
code
usingshutil.which
in addition to the existing methods so that the binary is found when being run from within a vscode remote shell. - If locating the code binary fails, only prompts to ask whether or not to continue, rather than requiring entering the complete path. The only use of the vscode command is to start an instance connected to the correct path, so if no binary was found, a message is logged instead. (bug 1699943)
- When changes need to be made to the settings.json file, a full diff is shown between the old and new files, rather than just showing the computed state before and after.
- If parsing the existing settings.json file fails (e.g. because there were c-style comments in it - see bug 1670997), the diff is shown and an additional warning is emitted to ask if the change should be made.
Assignee | ||
Comment 1•3 years ago
|
||
This patch has a few minor improvements to ./mach ide vscode
to make
it nicer to use in various situations. Specifically:
-
Tries to locate the
code
usingshutil.which
in addition to the
existing methods so that the binary is found when being run from
within a vscode remote shell. -
If locating the code binary fails, only prompts to ask whether or not
to continue, rather than requiring entering the complete path. The
only use of the vscode command is to start an instance connected to the
correct path, so if no binary was found, a message is logged instead.
(bug 1699943) -
When changes need to be made to the settings.json file, a full diff is
shown between the old and new files, rather than just showing the
computed state before and after. -
If parsing the existing settings.json file fails (e.g. because there
were c-style comments in it - see bug 1670997), the diff is shown and
an additional warning is emitted to ask if the change should be made.
Comment 3•3 years ago
|
||
bugherder |
Updated•2 years ago
|
Description
•