Closed Bug 1722833 Opened 2 years ago Closed 2 years ago

Pressed native buttons on macOS Monterey use white text on light gray

Categories

(Core :: Widget: Cocoa, defect, P2)

Product:
Core
Component:
Widget: Cocoa
Version:
Firefox 92
Platform:
All
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox92 --- wontfix
firefox95 --- verified

People

(Reporter: sam, Assigned: mstange)

References

(Blocks 1 open bug)

Details

(Whiteboard: [mac:integration])

Attachments

(4 files)

pressed-button.png
179.60 KB, image/png
Details
Bug 1722833 - Tweak default button :active state rendering. r=#desktop-theme-reviewers,#mac-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 1722833 - Add nsCocoaFeatures::OnMontereyOrLater(). r=#mac-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 1722833 - Make MozButtonactivetext use NSColor.controlTextColor on macOS 12+. r=#mac-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Attached image pressed-button.png —

With macOS Monterey in light mode, press any native-styled push button in Firefox, such as in Help > Troubleshoot Mode, or Library > Add Bookmark. The text will turn white, but on a light gray background, so it is unreadable.

This is likely due to the pressed button and pressed default button style changes in Monterey.

In the attached example, "Refresh Nightly" is pressed. The issue also occurs if a default button, such as "Open", is pressed (however, I believe in AppKit apps the default button stays blue).

Blocks: monterey
Status: UNCONFIRMED → NEW
Ever confirmed: true
Severity: -- → S2
Priority: -- → P2
Whiteboard: [mac:integration]
Attachment #9246170 - Attachment description: WIP: Bug 1722833 - WIP: Tweak button and default button rendering and text color in various states to match macOS Monterey. Needs testing on Big Sur. → WIP: Bug 1722833 - WIP: Tweak button and default button rendering and text color in various states to match macOS Monterey.
Assignee: nobody → mstange.moz
Attachment #9246170 - Attachment description: WIP: Bug 1722833 - WIP: Tweak button and default button rendering and text color in various states to match macOS Monterey. → Bug 1722833 - Tweak default button :active state rendering. r=#desktop-theme-reviewers,#mac-reviewers
Status: NEW → ASSIGNED
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/de071c6d60a7
Tweak default button :active state rendering. r=mac-reviewers,spohl
https://hg.mozilla.org/integration/autoland/rev/f718eaf8816e
Add nsCocoaFeatures::OnMontereyOrLater(). r=mac-reviewers,spohl
https://hg.mozilla.org/integration/autoland/rev/40fe290c7604
Make MozButtonactivetext use NSColor.controlTextColor on macOS 12+. r=mac-reviewers,spohl

https://hg.mozilla.org/mozilla-central/rev/de071c6d60a7
https://hg.mozilla.org/mozilla-central/rev/f718eaf8816e
https://hg.mozilla.org/mozilla-central/rev/40fe290c7604

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

Reproduced with Fx 93 on macOS 12.0.1.
Verified fixed under the same macOS version with Fx 95.0a1 (20211021093631).

Status: RESOLVED → VERIFIED
status-firefox95: fixed → verified
You need to log in before you can comment on or make changes to this bug.