172284 - checksetup assumes that there are < 99999 bugs

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect, P4)

Description

[Joel Peshkin]

By inspection.....

In checksetup.pl, the regexp appears to presume bug numbers are between 1 and 5
digits

        $sth = $dbh->prepare("SELECT longdescs.bug_id, thetext FROM longdescs le
ft JOIN bugs using(bug_id) WHERE (thetext " .
                "regexp '[.*.]{3,3} This bug has been marked as a duplicate of [
[:digit:]]{1,5} [.*.]{3,3}') AND (resolution = 'DUPLICATE') ORDER" .
                        " BY longdescs.bug_when");
        $sth->execute();

Comment 1

[Bradley Baetz (:bbaetz)]

Yes, it does (For that conversion).

Bleh, I fixed this for bug 151619 the next page down..

Anyway, this only affecst people who have more than 100000 bugs in a bugzilla
version before July 2000 (ie bz 2.12)

What is [.*.]{3,3} meant to match against? Is that just [.*]{3} ?

This should be changed to match what is a few lines later, using whatever mysql
3.22 syntax is, and then we should put this onto the 2.16 branch.

Comment 2

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Can't test though -- I don't have a 2.12 installation handy :)

Comment 3

[Max Kanat-Alexander]

Comment on attachment 176877 [details] [diff] [review]
Patch

I have a 2.12 install on landfill, and checksetup runs without dying with this
patch. :-) It looks correct, also.

Comment 4

[Shane H. W. Travis]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.367; previous revision: 1.366
done