checksetup assumes that there are < 99999 bugs

RESOLVED FIXED in Bugzilla 2.20

Status

()

P4
normal
RESOLVED FIXED
16 years ago
6 years ago

People

(Reporter: bugreport, Assigned: Wurblzap)

Tracking

2.17
Bugzilla 2.20
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
By inspection.....

In checksetup.pl, the regexp appears to presume bug numbers are between 1 and 5
digits

        $sth = $dbh->prepare("SELECT longdescs.bug_id, thetext FROM longdescs le
ft JOIN bugs using(bug_id) WHERE (thetext " .
                "regexp '[.*.]{3,3} This bug has been marked as a duplicate of [
[:digit:]]{1,5} [.*.]{3,3}') AND (resolution = 'DUPLICATE') ORDER" .
                        " BY longdescs.bug_when");
        $sth->execute();
Yes, it does (For that conversion).

Bleh, I fixed this for bug 151619 the next page down..

Anyway, this only affecst people who have more than 100000 bugs in a bugzilla
version before July 2000 (ie bz 2.12)

What is [.*.]{3,3} meant to match against? Is that just [.*]{3} ?

This should be changed to match what is a few lines later, using whatever mysql
3.22 syntax is, and then we should put this onto the 2.16 branch.

Updated

14 years ago
Assignee: zach → travis

Updated

14 years ago
Assignee: travis → mkanat

Updated

14 years ago
Priority: -- → P4
(Assignee)

Comment 2

14 years ago
Created attachment 176877 [details] [diff] [review]
Patch

Can't test though -- I don't have a 2.12 installation handy :)
(Assignee)

Updated

14 years ago
Assignee: mkanat → wurblzap
Status: NEW → ASSIGNED
Attachment #176877 - Flags: review?
Comment on attachment 176877 [details] [diff] [review]
Patch

I have a 2.12 install on landfill, and checksetup runs without dying with this
patch. :-) It looks correct, also.
Attachment #176877 - Flags: review? → review+

Updated

14 years ago
Flags: approval?
OS: other → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 2.20
Flags: approval? → approval+

Comment 4

14 years ago
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.367; previous revision: 1.366
done
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.