Stop using -4px margins on inline dialog margins in commonDialog and friends, and update all the children to account for this
Categories
(Toolkit :: Content Prompts, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox92 | --- | affected |
People
(Reporter: Gijs, Unassigned)
Details
commonDialog and a few other places use a 16px grid padding, but then subtract 4px which gets "added back" by all the inline items in the dialog, cf. https://searchfox.org/mozilla-central/rev/cfc40681e13089f92fb3f5f67d5d527fb04d9505/toolkit/components/prompts/content/commonDialog.css#103-105 .
In bug 1720262 I ended up doing a little dance to mimic this, but it ends up being more effort than just defining the 16px (or at least, it feels like that).
It would be nice if fixing this was straightforward, but IME it is tricky because of the button box in the dialog, whose margins are tricky to affect from outside of the anonymous content of the dialog.
I'm not 100% confident what the "right" solution here looks like, but the current stuff is a bit of a fudge.
|
||
Updated•4 years ago
|
|
||
Updated•2 years ago
|
Description
•