1723082 - IOUtils.read throws Uncaught DOMException error for large file

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect, P3)

Description

[Ping Chen [:rnons] (away)]

Test code

await IOUtils.read('a_3.9GB_file')

Error

Uncaught (in promise) DOMException: Encountered an unexpected error while reading file(...path...)

It's better to document the max file size supported, and throw a more specific error like NS_ERROR_FILE_TOO_BIG.

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1723082 - Support reading files > INT32_MAX in IOUtils r?gijs

Previously, if you attempted to read a file greater than INT32_MAX in size, we
would either fail to read the file (on release) or crash (on debug). This is
due to the implementation of _PR_MD_READ accepting an int32_t of bytes to read
instead of a uint32_t, which nsFileStream::Read accepts and passes on.

Depends on D131160

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/492f5ca3b592
Support reading files > INT32_MAX in IOUtils r=Gijs

Comment 3

[Alexandru Michis [:malexandru]]

Backed out 3 changesets (Bug 1741247, Bug 1723082, Bug 1736175) for causing PathUtils.normalize failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/72c397486d4cec809c954f4be3df881c2db93d56
Push with failures, failure log.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/688444ccc86a
Support reading files > INT32_MAX in IOUtils r=Gijs

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/688444ccc86a