Closed Bug 1723104 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 29849 - Add tests for streaming upload feature detects

Categories

(Core :: DOM: Networking, task, P4)

Product:
Core
Component:
DOM: Networking
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29849 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29849
Details from upstream follow.

b'Jake Archibald <jaffathecake@gmail.com>' wrote:

Add tests for streaming upload feature detects

Safari supports streams in Request objects, but not in fetch. The feature detect is a bit messy as a result. Hopefully this will ensure that the feature test continues to work.

I deliberately but "feature test" in the test name, so hopefully folks won't make it work without making the rest of the feature work too.

There's two versions of this test, as Chrome fails the latter https://bugs.chromium.org/p/chromium/issues/detail?id=1234368

Component: web-platform-tests → DOM: Networking
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 20 subtests

Status Summary

Firefox

OK : 4
PASS : 48
FAIL : 32

Chrome

OK : 4
PASS : 72
FAIL : 8

Safari

OK : 3
PASS : 33
FAIL : 27
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/fetch/api/basic/request-upload.any.html
Fetch with POST with ReadableStream containing String: FAIL (Chrome: PASS, Safari: FAIL)
Fetch with POST with ReadableStream containing null: FAIL (Chrome: PASS, Safari: FAIL)
Fetch with POST with ReadableStream containing number: FAIL (Chrome: PASS, Safari: FAIL)
Fetch with POST with ReadableStream containing ArrayBuffer: FAIL (Chrome: PASS, Safari: FAIL)
Fetch with POST with ReadableStream containing Blob: FAIL (Chrome: PASS, Safari: FAIL)
Fetch with POST with ReadableStream on 421 response should return the response and not retry.: FAIL (Chrome: FAIL, Safari: FAIL)
Feature detect for POST with ReadableStream: FAIL (Chrome: PASS, Safari: FAIL)
Feature detect for POST with ReadableStream, using request object: FAIL (Chrome: FAIL, Safari: FAIL)
/fetch/api/basic/request-upload.any.serviceworker.html
Fetch with POST with ReadableStream containing String: FAIL (Chrome: PASS, Safari: FAIL)
Fetch with POST with ReadableStream containing null: FAIL (Chrome: PASS, Safari: FAIL)
Fetch with POST with ReadableStream containing number: FAIL (Chrome: PASS, Safari: FAIL)
Fetch with POST with ReadableStream containing ArrayBuffer: FAIL (Chrome: PASS, Safari: FAIL)
Fetch with POST with ReadableStream containing Blob: FAIL (Chrome: PASS, Safari: FAIL)
Fetch with POST with ReadableStream on 421 response should return the response and not retry.: FAIL (Chrome: FAIL, Safari: FAIL)
Feature detect for POST with ReadableStream: FAIL (Chrome: PASS, Safari: FAIL)
Feature detect for POST with ReadableStream, using request object: FAIL (Chrome: FAIL, Safari: FAIL)
/fetch/api/basic/request-upload.any.worker.html
Fetch with POST with ReadableStream containing String: FAIL (Chrome: PASS, Safari: FAIL)
Fetch with POST with ReadableStream containing null: FAIL (Chrome: PASS, Safari: FAIL)
Fetch with POST with ReadableStream containing number: FAIL (Chrome: PASS, Safari: FAIL)
Fetch with POST with ReadableStream containing ArrayBuffer: FAIL (Chrome: PASS, Safari: FAIL)
Fetch with POST with ReadableStream containing Blob: FAIL (Chrome: PASS, Safari: FAIL)
Fetch with POST with ReadableStream on 421 response should return the response and not retry.: FAIL (Chrome: FAIL, Safari: FAIL)
Feature detect for POST with ReadableStream: FAIL (Chrome: PASS, Safari: FAIL)
Feature detect for POST with ReadableStream, using request object: FAIL (Chrome: FAIL, Safari: FAIL)
/fetch/api/basic/request-upload.any.sharedworker.html
Fetch with POST with ReadableStream containing String: FAIL (Chrome: PASS)
Fetch with POST with ReadableStream containing null: FAIL (Chrome: PASS)
Fetch with POST with ReadableStream containing number: FAIL (Chrome: PASS)
Fetch with POST with ReadableStream containing ArrayBuffer: FAIL (Chrome: PASS)
Fetch with POST with ReadableStream containing Blob: FAIL (Chrome: PASS)
Fetch with POST with ReadableStream on 421 response should return the response and not retry.: FAIL (Chrome: FAIL)
Feature detect for POST with ReadableStream: FAIL (Chrome: PASS)
Feature detect for POST with ReadableStream, using request object: FAIL (Chrome: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/655d3879a601 [wpt PR 29849] - Add tests for streaming upload feature detects, a=testonly https://hg.mozilla.org/integration/autoland/rev/c6c1308308ab [wpt PR 29849] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/655d3879a601
https://hg.mozilla.org/mozilla-central/rev/c6c1308308ab

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.