1723182 - IMIP button text unreadable with high contrast themes

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Richard Marti (:Paenglab)]

With high contrast themes, no matter if Linux or Windows, the IMIP button text is black on black. This makes a little bit hard read the button text.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1723182-prefers-contrast-IMIP-button-color.patch

This can be also tested with Linux HighContrastInverse.

Comment 2

[Geoff Lankow (:darktrojan)]

The colouring of this whole bar (#imip-bar) annoys me. It's fixed to #000 and #baeeff regardless of the theme, which causes this problem, and also the foreground colour is too dark compared to the not-quite-black of the default theme. Could we instead give it a separate colour combination for dark themes? WindowText and --viewTodayOffBackground seems like a good fit to me.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: prefers-contrast-IMIP-button-color.patch

Yes, use a different background colour is better. Using a little bit different colour for better contrast.

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9234217 [details] [diff] [review]
prefers-contrast-IMIP-button-color.patch

Better.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d21438a6cf99
Use the correct color for IMIP buttons with prefers-contrast. r=darktrojan

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9234217 [details] [diff] [review]
prefers-contrast-IMIP-button-color.patch

[Approval Request Comment]
User impact if declined: with HCT unreadable iMIP buttons
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9234217 [details] [diff] [review]
prefers-contrast-IMIP-button-color.patch

[Triage Comment]
Approved for esr91

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 91.0.2:
https://hg.mozilla.org/releases/comm-esr91/rev/818027eb7266