Merge securityOverlay.xul with navigator.xul

VERIFIED FIXED

Status

SeaMonkey
UI Design
VERIFIED FIXED
16 years ago
10 years ago

People

(Reporter: janv, Assigned: janv)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
 
(Assignee)

Comment 1

16 years ago
Created attachment 101525 [details] [diff] [review]
patch

Comment 2

16 years ago
Comment on attachment 101525 [details] [diff] [review]
patch

You'll probably have to remove the reference to the overlay from this file too:
/netwerk/test/jarlist.dat

sr=jag
Attachment #101525 - Flags: superreview+

Updated

16 years ago
Component: Browser-General → XP Apps: GUI Features
QA Contact: asa → sairuh
(Assignee)

Comment 3

16 years ago
kaie, could you review ?
(Assignee)

Comment 4

16 years ago
or bryner ?
Status: NEW → ASSIGNED

Comment 5

16 years ago
I'm reviewing now. Just curious, what was the motivation for merging? Less bloat?

Comment 6

16 years ago
Comment on attachment 101525 [details] [diff] [review]
patch

looks good
r=kaie
Attachment #101525 - Flags: review+

Comment 7

16 years ago
performance, overlays are very expensive. the only question is what happens if
an embedder decides not to build psm. i think the answer is that they get an
always unlocked icon or make there own chrome. both of those seem like
acceptable answers.
(Assignee)

Comment 8

16 years ago
Yes, less bloat and it should Txul a little bit.
Less overlays we have faster we are.
(Assignee)

Comment 9

16 years ago
fix checked in, thanks for reviews
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 10

16 years ago
We could do something where we check for a well known security contract ID and
hide the icon if the contract ID is not there.
rs vrfy.
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite

Updated

10 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.