Enable ESLint for SeaMonkey 2.53 and 2.57
Categories
(SeaMonkey :: General, enhancement)
Tracking
(seamonkey2.53+ fixed)
People
(Reporter: frg, Assigned: frg)
References
(Blocks 1 open bug)
Details
(Whiteboard: SM2.53.9)
Attachments
(2 files)
965 bytes,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
61.56 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Enable manual formatting for SeaMonkey 2.53 and 2.57 only. We don't want this for comm-central because the current lint rules in use there don't work for us. They imho produce badly formatted and hard to read source file.
Assignee | ||
Comment 1•3 years ago
|
||
[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: no linting
Testing completed (on m-c, etc.): 2.53.9b1 pre
Risk to taking this patch (and alternatives if risky): manual formatting only.
String changes made by this patch: --
Assignee | ||
Comment 2•3 years ago
•
|
||
TOP temporary patch for our 2.53 and 2.57 branches only. Setting up lint with current node binaries changes the format and in some cases the version numbers. Patch should go away with further backports and needs to be looked at later. Bug 1456085 removed the file.
[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: no lint
Testing completed (on m-c, etc.): 2.35.9b1 pre
Risk to taking this patch (and alternatives if risky): no risk
String changes made by this patch: --
Comment on attachment 9234159 [details] [diff] [review]
TOP-1723376-eslint-2539.patch
Why are some of the version numbers changing:
e.g. acorn 3.3.0 to 3.0.4?
Comment on attachment 9234158 [details] [diff] [review]
1723376-enablelint-2539.patch
[Triage Comment]
I guess we need a bug to remove getASTSource
Comment on attachment 9234159 [details] [diff] [review]
TOP-1723376-eslint-2539.patch
[Triage Comment]
r/a=me as a TOP patch
Assignee | ||
Comment 6•3 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/691417466ede4b04ea06bd5b551da8b961949e3a
Enable ESlint for suite. r=IanN a=IanN
https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/472d52d633dc51e8500292af589e140397b3d315
Fix up eslint. r=IanN a=IanN
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Description
•