Closed Bug 1723376 Opened 3 years ago Closed 3 years ago

Enable ESLint for SeaMonkey 2.53 and 2.57

Categories

(SeaMonkey :: General, enhancement)

SeaMonkey 2.57 Branch
enhancement
Not set
normal

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
seamonkey2.53
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: frg, Assigned: frg)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.9)

Attachments

(2 files)

Enable manual formatting for SeaMonkey 2.53 and 2.57 only. We don't want this for comm-central because the current lint rules in use there don't work for us. They imho produce badly formatted and hard to read source file.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: no linting
Testing completed (on m-c, etc.): 2.53.9b1 pre
Risk to taking this patch (and alternatives if risky): manual formatting only.
String changes made by this patch: --

Attachment #9234158 - Flags: review?(iann_bugzilla)
Attachment #9234158 - Flags: approval-comm-release?
Attachment #9234158 - Flags: approval-comm-esr60?

TOP temporary patch for our 2.53 and 2.57 branches only. Setting up lint with current node binaries changes the format and in some cases the version numbers. Patch should go away with further backports and needs to be looked at later. Bug 1456085 removed the file.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: no lint
Testing completed (on m-c, etc.): 2.35.9b1 pre
Risk to taking this patch (and alternatives if risky): no risk
String changes made by this patch: --

Attachment #9234159 - Flags: review?(iann_bugzilla)
Attachment #9234159 - Flags: approval-comm-release?
Attachment #9234159 - Flags: approval-comm-esr60?

Comment on attachment 9234159 [details] [diff] [review]
TOP-1723376-eslint-2539.patch

Why are some of the version numbers changing:
e.g. acorn 3.3.0 to 3.0.4?

Flags: needinfo?(frgrahl)

Comment on attachment 9234158 [details] [diff] [review]
1723376-enablelint-2539.patch

[Triage Comment]
I guess we need a bug to remove getASTSource

Attachment #9234158 - Flags: review?(iann_bugzilla)
Attachment #9234158 - Flags: review+
Attachment #9234158 - Flags: approval-comm-release?
Attachment #9234158 - Flags: approval-comm-release+
Attachment #9234158 - Flags: approval-comm-esr60?
Attachment #9234158 - Flags: approval-comm-esr60+

Comment on attachment 9234159 [details] [diff] [review]
TOP-1723376-eslint-2539.patch

[Triage Comment]
r/a=me as a TOP patch

Flags: needinfo?(frgrahl)
Attachment #9234159 - Flags: review?(iann_bugzilla)
Attachment #9234159 - Flags: review+
Attachment #9234159 - Flags: approval-comm-release?
Attachment #9234159 - Flags: approval-comm-release+
Attachment #9234159 - Flags: approval-comm-esr60?
Attachment #9234159 - Flags: approval-comm-esr60+
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: