1723445 - Modify rlbox library path computation for android compatibility

Status: RESOLVED FIXED

(Core :: General, enhancement, P3)

Description

[Shravan Narayan]

RLBox currently loads sandboxed code from a separate shared library. The path to this library has to be modified to operate correctly in the android package format for firefox.

(RLBox has not yet been deployed on android, so this is listed as an enhancement instead of a bug)

Comment 1

[Shravan Narayan]

Attachment: Bug 1723445 - Modify rlbox libpath for android compat r=tjr

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1723445 - Use MOZ_ANDROID_LIBDIR in BinaryPath::Get instead of GRE_HOME.

The use of GRE_HOME was cargo-culted well back when, and doesn't reflect
the reality of where the executables and libraries are on Android.
Libxul and its dependent libraries are actually loaded from
MOZ_ANDROID_LIBDIR, set from the Java side, and used in APKOpen.cpp,
matching reality more closely.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc9b9c1c8ab5
Use MOZ_ANDROID_LIBDIR in BinaryPath::Get instead of GRE_HOME. r=nika

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset bc9b9c1c8ab5 (Bug 1723445) for causing GTest crashes.
https://hg.mozilla.org/integration/autoland/rev/4769b6b07511126d6c0d88bd1b1f8de45703ff71

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=bc9b9c1c8ab5cd089850e3b2a39ea3f18b236794&selectedTaskRun=TfJl2uW5QP6Hp83lpHkrYA.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=348152337&repo=autoland&lineNumber=4307

Comment 5

[Shravan Narayan]

@glandium has taken over this change

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72b1ef452688
Use MOZ_ANDROID_LIBDIR in BinaryPath::Get instead of GRE_HOME. r=nika

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/72b1ef452688