Closed Bug 1723484 Opened 3 years ago Closed 3 years ago

Assess use of external GitHub action pre-commit/action in Mozilla's GitHub organization mozilla

Categories

(mozilla.org :: Github: Administration, task)

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: marco, Assigned: hwine)

Details

I want to use the pre-commit/action GitHub action in mozilla for the following reasons:
Running linting

Below are my answers to your stock questions:

** Which repositories do you want to have access? (all or list)
mozilla/grcov

** Are any of those repositories private?
No

** Provide link to vendor's description of permissions needed and why
Is this relevant with GitHub actions?

** Provide the Install link for a GitHub app
No install link, here's the action repository:
https://github.com/pre-commit/action

Of course, I can reimplement the action "manually" if it's better to avoid external actions as much as possible.

NI to opsec for their approval.

Flags: needinfo?(hwine)

similar to bug 1723483 comment 2, this needs some thinking.

:marco - note that this action is deprecated. Please use their recommended replacement, if possible.

Please update this ticket with the results of that integration working (for other folks).

Assignee: nobody → hwine
Flags: needinfo?(hwine) → needinfo?(mcastelluccio)
Flags: needinfo?(hwine)

Ah, I didn't notice it was deprecated! I'll switch to manually implementing that action, should be trivial.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(mcastelluccio)
Flags: needinfo?(hwine)
Resolution: --- → WONTFIX

(In reply to Marco Castelluccio [:marco] from comment #4)

Ah, I didn't notice it was deprecated! I'll switch to manually implementing that action, should be trivial.

Just curiosity - any reason to not use the "new" service?

(In reply to Hal Wine [:hwine] (use NI, please) from comment #5)

(In reply to Marco Castelluccio [:marco] from comment #4)

Ah, I didn't notice it was deprecated! I'll switch to manually implementing that action, should be trivial.

Just curiosity - any reason to not use the "new" service?

A couple of reasons:

  • I'm already using pre-commit as CLI in bugbug (Taskcluster CI though, not GitHub Actions), and so I'm already used to it;
  • I prefer the consistency of using a single CI system for everything, and not having to learn a new one and deal with its configuration and permissions and security and so on.

I've just noticed pre-commit.ci has support for autoupdating the pre-commit configuration though, that might be an enticing feature.

You need to log in before you can comment on or make changes to this bug.