1723556 - Convert `standaloneLazyFunction` to be initialized with a Stencil instead of JSFunction.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Nicolas B. Pierron [:nbp]]

As we want to compile off-thread without GC, we have to remove GC object references from CompileLazyfunction which would prevent the Stencil generation.

standaloneLazyFunction which setup the parser with the context needed to resume a Full-parse of a Lazy function expect a HandleFunction which is also mirrored by a RootedFunction in CompileLazyFunction body.

We should replace these by information stored on the CompilationInput and/or stored on the CompilationSyntaxParseCache introduced in Bug 1719194.

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Bug 1723556 - standaloneLazyFunction now uses CompilationInput.

CompileLazyFunction depends on the fact that we have an allocated BaseScript.
This restriction should be removed to reuse this code with Stencil. Either
Stencil created to abstract over these GC inputs, or Stencil taken from a
previous compilation.

This patch exposes the functionFlags as part of the CompilationInput, which
can later be mapped to a StencilScript/StencilScriptExtra input, as well as the
FunctionSyntaxKind computation which depends on function flags and immutable
flags.

The display atom of the compiled function is added to
CompilationSyntaxParseCache, as well as a ScriptStencilExtra made to reuse
initialization function of FunctionBox. These are initialized by copying the
function info, and adding the display atom to the parser cache, as already done
with inner functions.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:nbp, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Nicolas B. Pierron [:nbp]]

This is in my landing queue, I am currently working on the patches which are based on top of it, as soon as they are in a compiling shape I will look back at the feedback of this patch and merge it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc450c9e7bfe
standaloneLazyFunction now uses CompilationInput. r=arai

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bc450c9e7bfe