Open
Bug 1723786
Opened 4 years ago
Updated 28 days ago
Fallback urlbar searches are not recorded in formhistory
Categories
(Firefox :: Address Bar, defect, P3)
Firefox
Address Bar
Tracking
()
NEW
People
(Reporter: daleharvey, Unassigned)
Details
If you set maxResultCount to 0 in https://searchfox.org/mozilla-central/source/browser/components/urlbar/UrlbarPrefs.jsm#290 then the hueristic result is disabled, while this is true if the user enters a term in the Urlbar then a search will happen however it will not be recorded in formhistory.sqlite
I don't know what situation a user could get into in order to hit this case but filing to keep track
|
||
Comment 1•4 years ago
|
||
The problem is around these lines:
https://searchfox.org/mozilla-central/rev/064a1e6a2a6f6aa30be8bf4edea2f8408f779d4d/browser/components/urlbar/UrlbarInput.jsm#625-646
There is a fallback path in case we cannot build a heuristic result, and that path doesn't add to form history if URIFixup returns a truth-y .keywordAsSent
Severity: -- → S3
Priority: -- → P3
You need to log in
before you can comment on or make changes to this bug.
Description
•