1723838 - add webidl dns bindings

Status: RESOLVED FIXED

(WebExtensions :: General, task, P2)

Description

[Shane Caraveo (:mixedpuppy)]

Add serviceworker webidl bindings for the dns namespace

This is a simple api for a first attempt.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1723838 [mv3] add dns namespace webidl binding for serviceworker

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D121671	Bug 1723838 [mv3] add dns namespace webidl binding for serviceworker	mixedpuppy	rpl: Inactive

:mixedpuppy, could you please find another reviewer or abandon the patch if it is no longer relevant?

For more information, please visit auto_nag documentation.

Comment 3

[Suhaib Mujahid [:suhaib]]

Sorry for the noise, there was a problem with a Bugzilla API that caused the bot to think more people were inactive than normal (bug 1789646).

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1723838 - Tweak error reported from WebExtensions GenerateWebIDLBindings.py on unexpected type for optional parameters. r?willdurand!

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1723838 - Change 'void' to 'undefined' webidl type in WebExtensions GenerateWebIDLBindings.py helper script. r?willdurand!

A similar change have been applied to the webidl files related to WebExtensions APIs that were already defined
in mozilla-central as part of Bug 1659158.

This patch updates the python script to make sure that the new generate WebIDL files for the other WebExtensions
API that are not already in mozilla-central will use 'undefined' instead of 'void' as the return value type for
WebExtensions API methods that do not return any value.

Depends on D167591

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1723838 - Update ExtensionAPI.h.in jinja template to use NS_DECL_CYCLE_COLLECTION_WRAPPERCACHE_CLASS macro. r?willdurand!

A similar change have been applied in the C++ header files for the WebExtensions API WebIDL bindings that were already
part of the mozilla-central tree as part of Bug 1777574.

This patch is making sure that C++ header boilerplate file generated by the WebExtensions python script
GenerateWebIDLBindings.py that we will generate next for the other WebExtensions APIs not yet implemented
in mozilla-central will also use this new macro.

Depends on D167592

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1723838 - WebIDL bindings for the 'dns' WebExtensions API namespace. r?willdurand!

Depends on D167593

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99398345f229
Tweak error reported from WebExtensions GenerateWebIDLBindings.py on unexpected type for optional parameters. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/0a2a5ea24951
Change 'void' to 'undefined' webidl type in WebExtensions GenerateWebIDLBindings.py helper script. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/5fef28bf2f79
Update ExtensionAPI.h.in jinja template to use NS_DECL_CYCLE_COLLECTION_WRAPPERCACHE_CLASS macro. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/1de4e44dab92
WebIDL bindings for the 'dns' WebExtensions API namespace. r=willdurand,webidl,smaug

Comment 10

[Sandor Molnar]

https://hg.mozilla.org/mozilla-central/rev/99398345f229
https://hg.mozilla.org/mozilla-central/rev/0a2a5ea24951
https://hg.mozilla.org/mozilla-central/rev/5fef28bf2f79
https://hg.mozilla.org/mozilla-central/rev/1de4e44dab92