Closed
Bug 1723864
Opened 5 years ago
Closed 6 months ago
Consider changing mSleep (and values AWAKE, SLEEPING_NOT_OBSERVED, and SLEEPING_OBSERVED), to an enum type
Categories
(Core :: Gecko Profiler, task, P3)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
149 Branch
| Tracking | Status | |
|---|---|---|
| firefox149 | --- | fixed |
People
(Reporter: mozbugz, Assigned: dcarver, Mentored)
References
Details
(Whiteboard: [fp])
Attachments
(1 file)
mSleep in RegisteredThread.h, soon to be moved to new class ThreadRegistrationData when bug 1721939 lands, is currently an int, with the different possible values being static const int discrete values.
mSleep could be changed to an enum, and the values enum options.
(Spawned from https://phabricator.services.mozilla.com/D120815#3956611 , thank you Nazım.)
|
||
Updated•3 years ago
|
Mentor: canaltinova
|
||
Updated•3 years ago
|
Whiteboard: [fxp]
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
Whiteboard: [fxp] → [fxp-profiler]
|
Assignee | |
Updated•6 months ago
|
Assignee: nobody → dcarver
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•6 months ago
|
||
Pushed by dcarver@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/98f6b5926c90
https://hg.mozilla.org/integration/autoland/rev/31377db74fe4
Change mSleep type to an enum. r=canaltinova,profiler-reviewers
|
||
Comment 3•6 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox149:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
|
|
||
Updated•6 months ago
|
Severity: N/A → S4
|
||
Updated•5 months ago
|
QA Whiteboard: [qa-triage-done-c150/b149]
|
|
||
Updated•5 months ago
|
|
|
||
Updated•5 months ago
|
Whiteboard: [fxp-profiler] → [fp]
|
|
||
Updated•5 months ago
|
|
|
||
Updated•5 months ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•