1723951 - Icons for Bookmark Toolbar and Other Bookmarks from Customized Bookmark menu missing

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Adrian Florinescu [:aflorinescu]]

[Environment:]

Windows 10, Mac 11, Mac 10.15, Mac 10.14

[Steps:]

1. Open Firefox
2. Open Hamburger menu/ More Tools/ Customize.
3. Drag and drop the Bookmarks Menu to toolbar.
4. Close Customize and click on the customized Bookmarks icon.

[Actual Result:]

Bookmark Toolbar and Other Bookmarks have no icons .

[Expected Result:]

Bookmark Toolbar and Other Bookmarks have icons (as in the Bookmarks menu from Menu Bar)

[Regression Window:]

Found commit message:
Bug 1720534 - Clean up styles in Bookmarks Menu Button menupopups on Windows 7 and 10. r=desktop-theme-reviewers,dao

Comment 1

[:Gijs (he/him)]

Mike, were these intentional removals? If so, we should probably also drop e.g. https://searchfox.org/mozilla-central/rev/4b49a0dc50104e03ecadd1fd1902b27be6b9c0c8/browser/themes/osx/browser.css#152 ; if not, I guess we should put the icons back?

Comment 2

[Adrian Florinescu [:aflorinescu]]

Since we're looking at a cosmetic issue, this is more on the lines of an S4, hence setting as such.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Hm. This might be right, or it might have been a misinterpretation of the IA deck that got put together for these panels.

Hey Meridel, should the "Bookmark Toolbar" and "Other Bookmarks" item in the Bookmarks toolbar button menu have icons, like we have for the folders? We used to have them, but they got removed for Firefox 89 - was that removal part of the design, or did I misinterpret?

Comment 4

[Meridel [:meridel]]

Attachment: Figma.png

According to my records (see screenshot of Figma designs with the placeholder globe icons), both "Bookmark Toolbar" and "Other Bookmarks" item SHOULD have icons. I am not away of any reason why those would have been removed.

Now, at the time we designed this I believe we were waiting on icon delivery so perhaps we need direction on which icons to use? Emanuela, do you recall if we intended for this to be a globe in each case? It seems like the folder would make more sense than the globe...

Comment 5

[Itiel]

fwiw in the Bookmarks menu on the menubar the icons are appearing correctly. If we decide it should look otherwise we may want to match that menu as well.

Comment 6

[Itiel]

Attachment: Bookmarks menubar vs. Bookmarks toolbaritem

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1723951 - put icons back for bookmarks toolbar and other bookmarks folders in the bookmarks menu button, r?mconley

Comment 8

[:Gijs (he/him)]

Emanuela is out until after the cutoff for 92 uplifts so if we want to not regress this in 92 we can't wait for her. I'm going to assume that we should at least revert the icons for now, and if we then want to update them some more we can do it in 93/94.

Comment 9

[:Gijs (he/him)]

Comment on attachment 9237107 [details]
Bug 1723951 - put icons back for bookmarks toolbar and other bookmarks folders in the bookmarks menu button, r?mconley

Beta/Release Uplift Approval Request

• User impact if declined: Missing images in the bookmarks menu toolbar button's panel
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial re-addition of classes that get the menuitem their images back (the list-style-image CSS directives are still in the tree anyway)
• String changes made/needed: Nope

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56280f0a9681
put icons back for bookmarks toolbar and other bookmarks folders in the bookmarks menu button, r=mconley

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/56280f0a9681

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9237107 [details]
Bug 1723951 - put icons back for bookmarks toolbar and other bookmarks folders in the bookmarks menu button, r?mconley

Approved for 92.0b7.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/db7efb8d1e83

Comment 14

[Alin Ilea, Desktop QA]

Verified - Fixed in latest Nightly 93.0a1 (build id: 20210820095755) and Beta 92.0b7 (build id: 20210822190301) using Windows 10 and macOS 10.15. The bookmarks toolbar and other bookmarks icons are displayed accordingly in the customized toolbar Bookmarks menu.

Comment 15

[Mark Banner (:standard8)]

Dropping old NI request. This presumably is not a priority at the moment, and if the icons are desired to be changed in the future, this will likely come from UX.