1723958 - DevTools broken after using iframe picker with bfcache navigation

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

• enable fission
• open http://odvarko.com/tests/fission/case1/index.html
• open devtools
• navigate to https://www.wikipedia.org/
• go back
• in iframe dropdown select http://odvarko.com/tests/fission/case1/odvarko.com.html
• go forward
• go back

Markup view will be blank, console doesn't work, etc... The following error is visible in the logs:

JavaScript error: resource://devtools/server/connectors/js-window-actor/DevToolsFrameChild.jsm, line 247: Error: DevToolsFrameChild _createTargetActor was called more than once for the same Watcher (Actor ID: "server0.conn1.watcher2")

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can reproduce on my machine (Win10), my prefs are:

• fission.autostart => true
• devtools.target-switching.server.enabled => true
• fission.bfcacheInParent => true

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1723958 - [devtools] Use targetActor.originalWindow instead of window in bfcache navigation. r=jdescottes.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

I created a test that demonstrates the issue: https://phabricator.services.mozilla.com/D121727
It runs fine without fission, fails with fission + bfcache, and passes with fission enabled but bfcache disabled.
So we can say it is related to bfcache

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a3f6075172e
[devtools] Use targetActor.originalWindow instead of window in bfcache navigation. r=jdescottes.

Comment 5

[Marian-Vasile Laza]

Backed out changeset 3a3f6075172e (Bug 1723958) for causing xpcshell failures on test_addon_debugging_connect.js.
Backout link
Push with failures
Failure Log

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

oops, pushed a fix: https://treeherder.mozilla.org/jobs?repo=try&revision=cba1e3ecc9db2d6c092d8d72e26d0303a84c56c1

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bba88f3be2ff
[devtools] Use targetActor.originalWindow instead of window in bfcache navigation. r=jdescottes.

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/bba88f3be2ff