1723964 - update antenna to everett 2.0.0

Status: RESOLVED FIXED

(Socorro :: Antenna, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Everett redoes how configuration works for components. This bug covers updating Antenna to Everett 2.0.0 and updating configuration.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I started doing this when I was testing the changes in Everett 2.0.0. I have a bit more work to do.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

So the Everett update was a minor refactoring of a lot of connective tissue in Antenna.

I extracted a crashmover from the breakpad_resource code. Saving and publishing crash reports is separate from parsing them. If we decide to handle other crash report types other than Breakpad, we'll want to use the same crashmover. Separating this out simplifies some things, too.

I reworked some configuration variable names so they're shorter. BREAKPAD_THROTTLER_THROTTLE_RULES is now just BREAKPAD_THROTTLER_RULES.

I did a pass on fixing and improving the configuration documentation. I want it to be easy to read and understand for ops folks so they can set things the right way and understand when configuration values aren't right.

I refactored how logging and metrics are set up to match what I did with Eliot which I think is clearer especially as your cross over interface boundaries.

Because this changes variable names, we need to update the infrastructure code. The migration looks like this:

1. add the new variables to the infrastructure code, create a PR, land it
2. create a PR for antenna with the everett changes, land it
3. that'll deploy everything to stage
4. test everything on stage and make sure things are configured correctly
5. push to prod
6. remove the old variables from the infrastructure code, create a PR, and land it

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4347: antenna: bug 1723964: update configuration

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 736: bug 1723964: update everett, redo config, create crashmover

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

jasonthomas merged PR #4347: "antenna: bug 1723964: update configuration" in d2e2466.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #736: "bug 1723964: update everett, redo config, create crashmover" in e32682a.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 737: bug 1723964: fix logging default to INFO

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #737: "bug 1723964: fix logging default to INFO" in f0de0dd.

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 738: bug 1723964: fix sentry logging

Comment 10

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #738: "bug 1723964: fix sentry logging" in 7cd8356.

Comment 11

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 739: bug 1723964: fix localdevenv test and add dockerflow tests

Comment 12

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #739: "bug 1723964: fix localdevenv test and add dockerflow tests" in 20936d0.

Comment 13

[Will Kahn-Greene [:willkg] ET needinfo? me]

I pushed this to prod just now in bug #1724708. I updated the stage and prod dashboards because the "save crash" and "publish crash" metric keys had changed.

Marking as FIXED.