1724084 - Redundant colon in event dialog tab titles (Description, Attachments, Attendees) - convert entangled strings with variables to Fluent

Status: RESOLVED DUPLICATE of bug 1900119

(Calendar :: Dialogs, defect)

Description

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

I remember we did this at least two big releases ago because we were past string freeze, maybe we can finally get rid of the clutch:

In the event dialog, the tab titles have a colon at the end. This should be a quick fix.

Comment 1

[Thomas D. (:thomas8)]

Attachment: 1724084_calEditableItem_subTabTitles_Fluent.diff

This patch removes the trailing colon on the tab titles of Description, Attachments, and
Attendees on the calendar item dialogs. I also disentangled the rather nested current implementation of
these dynamic strings by converting them to Fluent - much cleaner now!

Comment 2

[Thomas D. (:thomas8)]

Thanks to :Paenglab for this try build:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=bcab01cf241986f2f90002b5e9540d428f7529fd
Busted, but not by my patch here...

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9235217 [details] [diff] [review]
1724084_calEditableItem_subTabTitles_Fluent.diff

Review of attachment 9235217 [details] [diff] [review]:
-----------------------------------------------------------------

Okay, but also I'd like to see the attendee and attachment functions in ItemEditingHelpers.jsm test that the `data-l10n-args` attributes are updated as expected. It should just be a matter of parsing the value before and after a change and checking the difference.

::: calendar/base/content/item-editing/calendar-item-iframe.js
@@ +3750,5 @@
> +
> +  // Update the attendee tab label to make the number of attendees visible
> +  // even if another tab is displayed.
> +  document.l10n.setAttributes(
> +    document.getElementById("event-grid-tab-attendees"),

No need to get this element again, it's `attendeeTab`.