1724094 - Remove the non-e10s xpcshell test configurations for extension tests

Status: NEW

(WebExtensions :: Android, task, P3)

Description

[Rob Wu [:robwu]]

It is not possible to disable e10s, see bug 1724089 for details.

So we should remove the browser.tabs.remote.autostart=false setter at https://searchfox.org/mozilla-central/rev/4b49a0dc50104e03ecadd1fd1902b27be6b9c0c8/toolkit/components/extensions/test/xpcshell/head.js#46 (because it does not work!!!), and reduce the number of distinct xpcshell test manifests.

The current list of tests is described at https://searchfox.org/mozilla-central/rev/4b49a0dc50104e03ecadd1fd1902b27be6b9c0c8/toolkit/components/extensions/test/xpcshell/xpcshell.ini#26-36:

• xpcshell-common.ini - included by xpcshell.ini and xpcshell-remote.ini
• xpcshell-common-e10s.ini - included by xpcshell-remote.ini and xpcshell-e10s.ini
• xpcshell-remote.ini --- e10s + OOP extensions = primary target (all desktop)
• xpcshell-content.ini -- included by xpcshell-remote.ini, xpcshell-e10s.ini and xpcshell.ini
• xpcshell-e10s.ini - e10s + in-process extensions = GeckoView (until bug 1535365 is fixed) however it is currently skipped on Android
• xpcshell.ini - "non-e10s" (e10s in practice) + in-process extensions (former target for Fennec) = GeckoView in practice

We should cut the number of test manifests to three:

• xpcshell-common.ini - unchanged
• xpcshell-common-e10s.ini - merge with xpcshell-remote.ini
• xpcshell-remote.ini - unchanged
• xpcshell-content.ini - merge with xpcshell-common.ini
• xpcshell-e10s.ini - delete (there are no other tests other than the inclusions)
• xpcshell.ini - change comment/tags to match reality: e10s + in-process extensions (GeckoView, until bug 1535365)

Besides merging the test manifests, we should also consolidate head.js (as mentioned before), head_e10s.js and head_remote.js, and check whether the skip-if = os == "android" are still needed (bug 1680132).

Comment 1

[Tomislav Jovanovic :zombie]

Hey Geoff, you might be interested in this because of Thunderbird, not sure how far along with e10s you are there.

Comment 2

[Geoff Lankow (:darktrojan)]

Fine by me, we're e10s by default.

Comment 3

[Geoff Lankow (:darktrojan)]

Actually, I think this would result in us running some tests we didn't previously run. I'll check that they are passing when I have a build again.

Comment 4

[Geoff Lankow (:darktrojan)]

Everything seems fine. We were skipping xpcshell-e10s.ini but I changed that and didn't have any failures. (We still need to skip xpcshell-legacy-ep.ini but you didn't mention that so I assume nothing is changing there.) Thanks for checking.

Comment 5

[Rob Wu [:robwu]]

Note: .ini is renamed to .toml in bug 1859899.

Comment 6

[Gregory Pappas [:gregp]]

Now that bug 1867597 is fixed, is e10s + in-process extensions still an important configuration to test?

Comment 7

[Rob Wu [:robwu]]

(In reply to Gregory Pappas [:gregp] from comment #6)

Now that bug 1867597 is fixed, is e10s + in-process extensions still an important configuration to test?

Yes. See bug 1535365, specifically https://bugzilla.mozilla.org/show_bug.cgi?id=1535365#c22 for details. In short, there are Android builds that still run with in-process extensions.

P.S. Thanks for removing head_e10s.js in bug 1863223.