1724149 - Fix test_interrupted_reflow.html on Fis+xorig runs

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Currently it's marked as fails-if=xorigin, not skip-if since it fails on finding the root content document scroller so that we can't collect scroll offsets properly.

Just opening a new tab and running the test in the new tab would solve the issue, but I am not 100% sure it's okay. IIUC the test purpose, it was for an issue on restoring scroll position (bug 1292781)? And restoring scroll position should happen only on the top level content root scroller I think, so it seems to be okay?

Comment 1

[Timothy Nikkel (:tnikkel)]

Hmm, the test seems to be written assuming it is the root content document? So I would think running it in a new tab would be a good idea.

Comment 2

[Frank Griffith Jr]

So for clarity....does the test need to be tweaked, rewritten, or some other action?

Comment 3

[Hiroyuki Ikezoe (:hiro)]

I will rewrite the test to open a new tab instead of running the test in an iframe.

Comment 4

[Chris Peterson [:cpeterson]]

Setting Fission Milestone = Future because this test fix doesn't need to block shipping Fission MVP, IIUC.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1724149 - Run the test in test_interrupted_reflow.html in a new tab. r?tnikkel

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2623e1197fd1
Run the test in test_interrupted_reflow.html in a new tab. r=tnikkel

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/2623e1197fd1

Comment 8

[Chris Peterson [:cpeterson]]

Setting status-firefox92=wontfix because I assume we don't need to uplift this test fix to Beta 92.