Wait for presShell in devtools addTab test helper
Categories
(DevTools :: General, task, P3)
Tracking
(firefox93 fixed)
| Tracking | Status | |
|---|---|---|
| firefox93 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(2 files)
In Bug 1722136 we are waiting for a valid presShell to avoid timeouts in a few tests which attempt to create popups early after creating a document.
The goal of this bug is to also apply this to our common addTab helper, when waitForLoad is not explicitly set to false: https://searchfox.org/mozilla-central/rev/00977c4e37865a92f1c15572ae4aea90e934b25b/devtools/client/shared/test/shared-head.js#413-414
A quick try push seems to show that we get timeouts however, so we should investigate this in more details.
|
Assignee | |
Comment 1•3 years ago
|
||
The failures when using waitForPresShell in addTab seem easy to fix.
Let's see if this would help the current situation with devtools intermittents.
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D122696
|
|
Assignee | |
Comment 4•3 years ago
|
||
It seems to at least fix the timeout on browser_rules_content_02.js https://treeherder.mozilla.org/jobs?repo=try&revision=56f002edac66ca6bdad03988ffe9324cd599839f (0 occurrence).
I was hoping for more impact on other existing tests but we still seem plagued by many other intermittents which have nothing to do with missing presShells.
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/395edf65fd33 [devtools] Rely on promise instead of message in sw push mochitests r=Honza https://hg.mozilla.org/integration/autoland/rev/b04e09887934 [devtools] Wait for presShell in all devtools test helper addTab r=Honza
This may be causing failures in devtools/client/framework/test/browser_enable_devtools_popup_new_user.js
I guess that has been filed as bug 1724207.
|
|
Assignee | |
Comment 8•3 years ago
|
||
(In reply to mac198442 from comment #6)
This may be causing failures in devtools/client/framework/test/browser_enable_devtools_popup_new_user.js
No it shouldn't, the fix was just moved from browser_enable_devtools_popup_new_user.js to a shared helper which is also used by browser_enable_devtools_popup_new_user.js.
The failures logged in Bug 1724207 are only test-verify, which is not compatible with this test.
|
||
Comment 9•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/395edf65fd33
https://hg.mozilla.org/mozilla-central/rev/b04e09887934
Description
•