1724187 - Marker stacks captured with ChromeUtils.addProfilerMarker(name, {captureStack: true}) should not show the addProfilerMarker function

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P3)

Description

[Florian Quèze [:florian]]

In bug 1674476 I added support for capturing a profiler stack to go with a marker added with ChromeUtils.addProfilerMarker. Currently these stacks start with a few frames in the DOM category, because the webidl binding code adds a label frame of the DOM category when calling the ChromeUtils method.

We could make the profiler ignore these frames by changing the label's category to PROFILER.

Example profile with the patch: https://share.firefox.dev/3yqiOxm
Similar profile without the patch: https://share.firefox.dev/3fBgTi2

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1724187 - Change the category of the ChromeUtils.addProfilerMarker label frame to PROFILER so that this code is ignored in stacks captured for profiler markers, r=gerald.

Comment 2

[Florian Quèze [:florian]]

Attachment: Bug 1724187 - Make the test_addProfilerMarker.js test check the content of marker stacks,

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a33b980dc978
Change the category of the ChromeUtils.addProfilerMarker label frame to PROFILER so that this code is ignored in stacks captured for profiler markers, r=gerald.
https://hg.mozilla.org/integration/autoland/rev/dc51620c74e7
Make the test_addProfilerMarker.js test check the content of marker stacks, r=julienw

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a33b980dc978
https://hg.mozilla.org/mozilla-central/rev/dc51620c74e7